startlxqt: Consider LXQT_DEFAULT_OPENBOX_CONFIG #60

Merged
merged 1 commit into from Aug 22, 2016

Conversation

Projects
None yet
4 participants
Contributor

palinek commented Aug 22, 2016

Use the LXQT_DEFAULT_OPENBOX_CONFIG as the predefined configuration for
openbox in case it is defined -> allow downstream to easily change the
default configuration.

Contributor

palinek commented Aug 22, 2016

Looking at the diff now... should we check the existence of $LXQT_DEFAULT_OPENBOX_CONFIG file?

Contributor

paulolieuthier commented Aug 22, 2016

I think so.

Contributor

luis-pereira commented Aug 22, 2016

IMO we should

Member

tsimonq2 commented Aug 22, 2016

This would be especially useful for Lubuntu's switch to LXQt so we can use a custom Openbox file. :)

For what it's worth, even though my Bash is rusty, 👍

(this came from a discussion I had on IRC)

And on your question, although again, my opinion doesn't carry much weight (as I'm not an LXQt developer) I think that would be good to check for that.

Contributor

palinek commented Aug 22, 2016

The checking done...

Contributor

luis-pereira commented Aug 22, 2016

Ship it

Contributor

paulolieuthier commented Aug 22, 2016

GTM.

startlxqt: Consider LXQT_DEFAULT_OPENBOX_CONFIG
Use the LXQT_DEFAULT_OPENBOX_CONFIG as the predefined configuration for
openbox in case it is defined -> allow downstream to easily change the
default configuration.

@palinek palinek merged commit 8f872cf into master Aug 22, 2016

@palinek palinek deleted the downstream_ob_config branch Aug 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment