From 660ffb5fe07902eb6eca327b782964fc9bc2fa3b Mon Sep 17 00:00:00 2001
From: Tsu Jan <tsujan2000@gmail.com>
Date: Tue, 14 Dec 2021 19:28:07 +0330
Subject: [PATCH] A better layout for config dialog

As suggested by @stefonarch.

Closes https://github.com/lxqt/lxqt-notificationd/issues/289
---
 config/basicsettings.ui | 13 -------------
 config/mainwindow.cpp   | 10 +++++-----
 2 files changed, 5 insertions(+), 18 deletions(-)

diff --git a/config/basicsettings.ui b/config/basicsettings.ui
index ccc4b78a..846a89f6 100644
--- a/config/basicsettings.ui
+++ b/config/basicsettings.ui
@@ -11,19 +11,6 @@
    </rect>
   </property>
   <layout class="QVBoxLayout" name="verticalLayout">
-   <item>
-    <widget class="QLabel" name="label">
-     <property name="font">
-      <font>
-       <weight>75</weight>
-       <bold>true</bold>
-      </font>
-     </property>
-     <property name="text">
-      <string>Basic Settings</string>
-     </property>
-    </widget>
-   </item>
    <item>
     <widget class="QGroupBox" name="groupBox">
      <property name="title">
diff --git a/config/mainwindow.cpp b/config/mainwindow.cpp
index 63c9cea3..16f1fd79 100644
--- a/config/mainwindow.cpp
+++ b/config/mainwindow.cpp
@@ -40,13 +40,13 @@
 MainWindow::MainWindow(QWidget *parent) :
     LXQt::ConfigDialog(tr("Desktop Notifications"), new LXQt::Settings(QSL("notifications")), parent)
 {
-    BasicSettings* basic = new BasicSettings(mSettings, this);
-    addPage(basic, tr("Basic Settings"), QSL("preferences-desktop-notification"));
-    connect(this, &MainWindow::reset, basic, &BasicSettings::restoreSettings);
-
     AdvancedSettings* menu = new AdvancedSettings(mSettings, this);
-    addPage(menu, tr("Advanced Settings"), QSL("preferences-desktop-notification-bell"));
+    addPage(menu, tr("General Settings"), QSL("preferences-desktop-notification-bell"));
     connect(this, &MainWindow::reset, menu, &AdvancedSettings::restoreSettings);
+
+    BasicSettings* basic = new BasicSettings(mSettings, this);
+    addPage(basic, tr("Position"), QSL("preferences-desktop-notification"));
+    connect(this, &MainWindow::reset, basic, &BasicSettings::restoreSettings);
 }
 
 MainWindow::~MainWindow()