Merge World Clock and Date/Time plugins

[jleclanche]

Good cleanup now that we no longer support qt < 5.3

[jleclanche]

@kuzmas would you like to take this?

[kuzmas]

@jleclanche ok

[jleclanche]

@kuzmas Targeting a december release if possible (pre-christmas). I'm tentatively leaving this on the 0.9 milestone.

[paulolieuthier]

@kuzmas you can push your current work to a branch, if you want help.

[kuzmas]

'Wordlclock' is friendlier now, 'clock' is turned off by default.

I have some ideas for future:

1. Add formats 'H:mm AP'/'HH:mm' and 'H:mm:ss AP'/'HH:mm:ss'. For that we need to detect whether current locale uses AM/PM or not.
2. Add special case for 'local timezone' (currently if no timezones specified in the list - it shows local timezone, but it would be nice to have it as an item in a list as well)

@jleclanche And as to non-constant width: we can make sure font in theme is monospaced, otherwise we can calculate the widest possible combination of datetime values and use its width as fixed (it can potentially take long to iterate through all combinations, since datetime format can contain anything)

Close this issue? All in favour?

[jleclanche]

@kuzmas I haven't tested yet but last I checked. world clock needed some severe improvements in order to be as good as clock; namely in the configuration.

[jleclanche]

BTW, if the two are considered merged, please remove the "clock" plugin and replace it by the worldclock plugin. Will need to test upgrade paths from 0.8 too.

[kuzmas]

@jleclanche well, technically they aren't merged, it's just worldclock covers all functionality of clock plus a lot more.

And I agree, configuration is a bit complicated. I'm open to suggestions.

[jleclanche]

@kuzmas ill do a UX pass on it when I get time.

[pepa65]

Would it be possible to show the list with all timezones chosen under the calendar (like eg. gsimplecal)?

[kuzmas]

@pepa65 I'm not sure what you mean. Worldclock has the list of all timezones in configuration. It can show time of all selected timezones, it can show the calendar and the calendar (current day and the first day of the week) depends on the shown timezone.

[kuzmas]

UX is in another issue: #416

[pepa65]

I was just checking again what I meant. I seem to remember that the timezones + times were all in the balloon-popup. I'm just now running lxqt-panel 0.8.0 and I think the configuration is great, but I can't see any way to show the timezones; hovering does nothing, left-click just shows the calendar.

[kuzmas]

@pepa65 ah, I see. It's middle click.

[pepa65]

OK, middle click does show the configured times, but there is no label, and no mention of which timezone, just a list of times. (But I hope -assume- this is fixed now.)

[pepa65]

(Sorry, that's just in the default Short form. It is very configurable! The only thing that some other world clock widgets allow me to do is define my own label for each zone...)

[kuzmas]

In 0.8.0 it shows time for all selected timezones exactly as it shows in panel it self.
Now I'm changing it so the timezone is appended anyway.

[kuzmas]

allow me to do is define my own label for each zone

this sounds like something I'd like for myself as well ;-)

[kuzmas]

me: Now I'm changing it so the timezone is appended anyway.

Time zone IANA id is appended to each label in the popup window unless time zone is already shown in some way.

[pmattern]

This issue was closed without getting solved besides everyone involved agreed that it's valid, stating #416 as successor is wrong as that one was only about improving plugin-worldclock.
Hence reopening. Unassigning kuzmas as he recently stated that he's no longer active in this project.

Right now both plugins are basically providing the same features, in particular the actual display in panel is the same as well as the calendar that comes up by (left) clicking.
plugin-worldclock offers the features reflected in its name in addition but lacks the tooltip displaying date and time on hovering.

What I'd suggest is adding the tooltip feature to plugin-worldclock and then rename it to plugin-clock. The latter seems reasonable to me as I figure terms like "clock" or "Date & Time" are rather what users unaware of the naming will look for.

[jleclanche]

@pmattern Can you take the issue?

[pmattern]

@jleclanche
Given my pretty limited programming skills I cannot handle this in the time I've got right now. So no, sorry.

[jleclanche]

@palinek @paulolieuthier @luis-pereira I need one of you guys to take it if it's to land in 0.10, otherwise we move it to .11.

[palinek]

IMO it's too late to merge it until 0.10. I am not in mood to do such merging. I am not a fan of the worldclock plugin at all (altough I don't see any evident reason for such antipathy 😄).

[jleclanche]

Moving to 0.11. I think we'll need to have a discussion about this, I was hoping they were closer to each other.

[pmattern]

[...] not in mood to do such merging [...] not a fan of the worldclock plugin at all

Not quite following here, tbh.
If we handled the plugins as stated in my second to last comment (of course a suggestion only) there would just be one plugin "Clock" or "Date & Time" or whatever that happens to provide some world-clock stuff in additon. But making use of the latter wouldn't be mandatory at all and the plugin wouldn't be called plugin-<foo...bar...world-clock somehow included here> either.
So what would be so bad about this? Or am I missing something?

[jleclanche]

@pmattern in the end it's up to whether people are actually willing to do it, it's not enough to ideally want it. anyway we have a release in a week, so let's focus.

[pmattern]

If this should get implemented one day I think it would be pretty good if the resulting plugin featured the tooltip displaying the complete date upon hovering

which is provided by plugin-clock but missing in plugin-worldclock right now.

[pepa65]

Worldclock in 0.10 has all functionality I could wish for, and is very configurable. Indeed, the only welcome addition would be a configurable popup. Then I would only show the time, but hover to see the date. And the world clock functionality is very important to me. At this point, LXQt is fully usable! (except the small matter of actually remembering the arandr configuration for a session...)

[tsimonq2]

I'm going to attempt to get this done. I'll work on it more in the next few days.

[tsimonq2]

Bump on this, this is now a WIP and available as a branch on lxqt-panel (now that I'm a member of the project on GitHub).

I expect to have this done by the middle of June, late June at the latest.

[tsimonq2]

Actually, I made a lot of progress tonight, and I just submitted a PR.

I look forward to feedback on it. :)

[palinek]

Closing this as the plugin-clock was deprecated in lxqt/lxqt-panel#426 and the follow-up is stated in #1356