Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous double-space in issue template #1470

Merged
merged 1 commit into from Mar 28, 2018

Conversation

ChlorideCull
Copy link
Contributor

Removes the presumably accidental double-space after "liblxqt Version:" towards the bottom of the issue template.

This has to be the most petty and unnecessary pull request I've ever done.

Removes the presumably accidental double-space after "liblxqt Version:"
@tsujan
Copy link
Member

tsujan commented Mar 28, 2018

Recently, I learned that those double-spaces meant a newline.

@ChlorideCull
Copy link
Contributor Author

True, but this is in a list you're supposed to fill in.

There's no visual difference between my version and the current version, in fact, I think the generated HTML output might be the same.

Once you fill the list in, it's no longer at the end either, so it doesn't make a difference outside the source view.

Again, really petty and unnecessary :)

@tsujan
Copy link
Member

tsujan commented Mar 28, 2018

I think the generated HTML output might be the same.

Maybe because that's a list or, perhaps, markdown is inconsistent about double-spaces.

Again, really petty and unnecessary :)

As far as I've seen, almost nothing is trivial. We started to think about Markdown's trailing double-spaces after all ;)

@tsujan
Copy link
Member

tsujan commented Mar 28, 2018

It's a mess ;) https://daringfireball.net/projects/markdown/syntax and http://spec.commonmark.org/0.28/#hard-line-breaks tell about double-spaces but don't exclude lists. Moreover, as I said elsewhere, I found nothing about tabs. I hate it when docs aren't specific....

EDIT: Anyhow, we don't need those spaces.

@palinek
Copy link
Contributor

palinek commented Mar 28, 2018

GTM

@ChlorideCull
Copy link
Contributor Author

I think <li> elements don't count as inline content, so the double-space rule doesn't apply to them.

As for tabs, it says towards the top that they are not expanded to spaces, but when used for defining structure, it counts as four spaces. Means you can use them for indenting code blocks, but they are preserved verbatim inside inline content.

@tsujan
Copy link
Member

tsujan commented Mar 28, 2018

OK. Let's merge this.

@tsujan tsujan merged commit f2d42f0 into lxqt:master Mar 28, 2018
@agaida agaida added this to Done in Pull Requests Mar 29, 2018
@agaida agaida added this to Done in PRs Nov 4, 2018
@agaida agaida added this to Old Archive in Pull Requests Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
PRs
  
Done
Pull Requests
  
Old Archive (fucked up)
Development

Successfully merging this pull request may close these issues.

None yet

3 participants