New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression. Places pannel has wrong font color #696

Closed
IMbackK opened this Issue Jun 12, 2018 · 5 comments

Comments

3 participants
@IMbackK
Copy link

IMbackK commented Jun 12, 2018

In PCManFM-Qt version 0.13.0 the font color in the places pannel backround was changed to be the window background color. The font color was retained as the content font color, making it unreadble in some themes.

@IMbackK

This comment has been minimized.

Copy link

IMbackK commented Jun 12, 2018

screenshot_20180612_144717

@PCMan

This comment has been minimized.

Copy link
Member

PCMan commented Jun 12, 2018

@tsujan I guess this issue is caused by the change here:
lxqt/libfm-qt@6803d32

@tsujan

This comment has been minimized.

Copy link
Member

tsujan commented Jun 12, 2018

I think the issue is in the theme/color scheme and should be seen in other places too.

@IMbackK, which theme do you use?

@tsujan

This comment has been minimized.

Copy link
Member

tsujan commented Jun 12, 2018

Qt's explanation about palettes (italics is mine):

"QPalette::Text → The foreground color used with Base. This is usually the same as the WindowText, in which case it must provide good contrast with Window and Base."

Logically, this doesn't mean that QPalette::Text and QPalette::WindowText (or QPalette::Window and QPalette::Base) should NOT have a high contrast with each other (because the word "usually" is used). However, the lack of high contrast is presupposed in several places. For example, symbolic SVG icons in KDE and LXQt only use QPalette::WindowText, so that they will be invisible in some places with a theme like that of the above screenshot.

@tsujan tsujan self-assigned this Jun 12, 2018

@tsujan tsujan added the enhancement label Jun 12, 2018

tsujan added a commit to lxqt/libfm-qt that referenced this issue Jun 12, 2018

@tsujan

This comment has been minimized.

Copy link
Member

tsujan commented Jun 12, 2018

Done in lxqt/libfm-qt#214.

However, as said above, themes whose base and window backgrounds have a high contrast with each other are poorly supported by Qt and will cause problems here and there. That's an old Qt issue.

tsujan added a commit to lxqt/libfm-qt that referenced this issue Jun 13, 2018

Use window text color for places view (#214)
* Use window text color for places view

Closes lxqt/pcmanfm-qt#696

* Do Places's visual merging in sidepane code

@agaida agaida added this to test in Issues Aug 11, 2018

@agaida agaida added this to Done in Issues Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment