Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove X11 WM menu code and option #931

Closed
tsujan opened this issue Apr 5, 2019 · 5 comments · Fixed by #937
Closed

Remove X11 WM menu code and option #931

tsujan opened this issue Apr 5, 2019 · 5 comments · Fixed by #937
Projects
Issues

Comments

@tsujan
Copy link
Member

tsujan commented Apr 5, 2019

Reasons:

  • It can confuse users ("How can I configure desktop?");
  • Having no real use, it hides the more important context menu(s) of pcmanfm-qt; and
  • Although I prefer X11 to Wayland for now, X11 codes won't be maintainable sooner or later.

Any objection?
@jubalh
Copy link
Member

jubalh commented Apr 5, 2019

Although I prefer X11 to Wayland for now, X11 codes won't be maintainable sooner or later.

That will take quite some time :D

@tsujan
Copy link
Member Author

tsujan commented Apr 5, 2019

That will take quite some time :D

It will, probably.

The speed with which KDE/KWin devs improve their Wayland support is amazing -- selection clipboard should be added soon and what I hate about not being able to position windows might be worked around (I hope).

Our sticking with not so useful X11 codes for the sake of WMs that haven't been developed for years doesn't seem like a good idea to me. LXQt is a classic DE but "classic" doesn't mean a love for ancient things .

@agaida
Copy link
Member

agaida commented Apr 5, 2019

not every WM has a Menu system implemented - so, if it make our code cleaner and easier to maintain - lets drop it.

@agaida agaida added this to Needs triage in Issues Apr 5, 2019
@tsujan
Copy link
Member Author

tsujan commented Apr 5, 2019

not every WM has a Menu system implemented

An additional reason I forgot to mention.

In old times, Openbox seemed to be "our" WM and we didn't think about running LXQt components under Wayland; hence that option. Now, that's changed.

@luis-pereira
Copy link
Member

luis-pereira commented Apr 5, 2019 •
edited

It has no real use, IMO.
No objection.

EDIT: typo

tsujan added a commit that referenced this issue Apr 12, 2019
@tsujan
Removed WM menu from desktop
f72e77a 
Because:
(1) Only some X11 WMs have desktop context menus, while LXQt is WM-agnostic;
(2) It hid our FM desktop context menu; and
(3) X11 codes should be kept only when really useful because they are an obstacle to preparing for Wayland.

NOTE: "Advanced" is preserved for the tab name because an extra item is added to it outside LXQt.

Closes #931
@tsujan tsujan mentioned this issue Apr 12, 2019
Merged
Issues automation moved this from Needs triage to Closed Apr 13, 2019
agaida pushed a commit that referenced this issue Apr 13, 2019
@tsujan @agaida
Removed WM menu from desktop
b6f1101 
Because:
(1) Only some X11 WMs have desktop context menus, while LXQt is WM-agnostic;
(2) It hid our FM desktop context menu; and
(3) X11 codes should be kept only when really useful because they are an obstacle to preparing for Wayland.

NOTE: "Advanced" is preserved for the tab name because an extra item is added to it outside LXQt.

Closes #931
@aginiewicz aginiewicz mentioned this issue May 2, 2020
Closed
@NsCDE NsCDE mentioned this issue Sep 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Issues
  
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed WM menu from desktop lxqt/pcmanfm-qt
4 participants
@luis-pereira @tsujan @agaida @jubalh