Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text selection is not replaced when proposal is applied #13

Closed
xcariba opened this issue Jun 30, 2020 · 1 comment
Closed

Text selection is not replaced when proposal is applied #13

xcariba opened this issue Jun 30, 2020 · 1 comment
Assignees
@xcariba
Labels
bug Something isn't working
Milestone
v0.2

Comments

@xcariba
Copy link
Collaborator

xcariba commented Jun 30, 2020

When text is selected in text editor and proposal is applied proposal is inserted after cursor and selection is ignored

Steps to reproduce:

  1. Write something like MyObject.FirstField
  2. Select FirstField with cursor between dot and F so FirstField text is selected
  3. Call content-assist
  4. Select and apply any proposal (for example SecondField)
  5. Selection will be ignored. Result will be MyObject.SeconfFieldFirstField
@xcariba xcariba self-assigned this Jun 30, 2020
@xcariba xcariba linked a pull request Jun 30, 2020 that will close this issue
If editor has text selection - replace selection with new text #12
Closed
@pisv
Copy link
Collaborator

pisv commented Jul 2, 2020

Can reproduce. Thank you!

@pisv pisv added the bug Something isn't working label Jul 2, 2020
@pisv pisv added this to the v0.2 milestone Jul 2, 2020
pisv added a commit that referenced this issue Jul 2, 2020
@pisv
Fix #13 - Text selection is not replaced when proposal is applied
4409b48
@pisv pisv closed this as completed in d10ff20 Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcariba xcariba

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2
Development

Successfully merging a pull request may close this issue.

If editor has text selection - replace selection with new text lxtk-org/lxtk
2 participants
@xcariba @pisv