Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache example to README #146

Merged
merged 4 commits into from Jul 27, 2022
Merged

Add cache example to README #146

merged 4 commits into from Jul 27, 2022

Conversation

tooomm
Copy link
Contributor

@tooomm tooomm commented Jul 16, 2022

Such an example never made it to the docs after the feature got introduced (lycheeverse/lychee#443).

Now, that lycheeverse/lychee#647 is resolved and --cache works again... 馃憤

What do you think about my approach and the cache setup?
Would you adjust the default cache age value, or do you think some comments could be helpful?

README.md Outdated Show resolved Hide resolved
@mre
Copy link
Member

mre commented Jul 18, 2022

Great idea, I like it! Should we add another step at the end which stores the cache for the next run? I'd assume that's what most people would want to do. Apart from that it looks fine.

README.md Show resolved Hide resolved
@tooomm
Copy link
Contributor Author

tooomm commented Jul 27, 2022

0.10.1 is the default version now. 馃帀 Can you update that section and I'll merge it right away?

I updated the docs accordingly, and thanks for taking care of including the explanation. 馃憤

@mre mre marked this pull request as ready for review July 27, 2022 21:56
@mre mre merged commit 6bbdba0 into lycheeverse:master Jul 27, 2022
@mre
Copy link
Member

mre commented Jul 27, 2022

Noice! Let's gooo! 馃殌

@tooomm tooomm deleted the patch-1 branch July 27, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants