Updated to working version of left-pad #3

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@camwest

camwest commented Mar 22, 2016

No description provided.

@mridgway

This comment has been minimized.

Show comment
Hide comment

Resolves #1

@doowb

This comment has been minimized.

Show comment
Hide comment
@doowb

doowb Mar 22, 2016

perhaps conider using pad-left instead. it's not having issues on npm and it's orders of magnitude faster because it uses repeat-string

doowb commented Mar 22, 2016

perhaps conider using pad-left instead. it's not having issues on npm and it's orders of magnitude faster because it uses repeat-string

@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Mar 22, 2016

It's a bad idea to use ^ and 0.x together.

It's a bad idea to use ^ and 0.x together.

@taion

This comment has been minimized.

Show comment
Hide comment
@taion

taion Mar 22, 2016

I'd amend @michaelficarra's point to say that using ^0.0.9 makes no sense, since that only matches 0.0.9 exactly.

It'd make the most sense to use a version that actually has correct semver semantics, or else switch to the faster pad-left entirely, per @doowb.

taion commented Mar 22, 2016

I'd amend @michaelficarra's point to say that using ^0.0.9 makes no sense, since that only matches 0.0.9 exactly.

It'd make the most sense to use a version that actually has correct semver semantics, or else switch to the faster pad-left entirely, per @doowb.

@camwest camwest closed this Mar 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment