Fixes the display name issues for tables, and tags count #69
Conversation
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=======================================
Coverage 74.11% 74.11%
=======================================
Files 19 19
Lines 989 989
Branches 84 84
=======================================
Hits 733 733
Misses 234 234
Partials 22 22
Continue to review full report at Codecov.
|
verdan
changed the title
|
@feng-tao @jinhyukchang ready for review Update: Added some helper functions in atlasclient, that would make things easier. waiting for the next release of atlasclient. |
verdan
changed the title
|
@verdan CI fails |
|
@feng-tao yes, because the new atlasclient is not yet released. Will be fixed once that's there. Will ping you once done. |
verdan
changed the title
|
@feng-tao ready for review. We need to fork the atlasclient as the maintainer was not active enough, and we want to speed up the development on Amundsen-Atlas now. |
| @@ -18,23 +19,18 @@ | |||
| LOGGER = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| # noinspection PyMethodMayBeStatic | |||
There was a problem hiding this comment.
just curious: what is this line about?
There was a problem hiding this comment.
This makes pycharm not to give warning about the method being static.
| @@ -59,4 +59,5 @@ neo4j-driver==1.6.0 | |||
| neotime==1.0.0 | |||
| pytz==2018.4 | |||
| statsd==3.2.1 | |||
| atlasclient==0.1.7 | |||
| pyatlasclient==1.0.0 | |||
There was a problem hiding this comment.
Yes. We'll be working on this one. (for all microservices)
|
|
||
| requirements_path = os.path.join(os.path.dirname(os.path.realpath(__file__)), 'requirements.txt') | ||
| with open(requirements_path) as requirements_file: | ||
| requirements = requirements_file.readlines() |
There was a problem hiding this comment.
actually there is some concern over pin the deps in amundsen-io/amundsen#80
|
thanks @verdan ! |
Summary of Changes
WIP: Made some changes in atlasclient, waiting for them to be fixed and released before this change.
This PR involves three changes:
Tests
Based on the changes above, I needed to modify the atlas proxy test cases.
Documentation
What documentation did you add or modify and why? Add any relevant links then remove this line
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test