[LYFT][STRMCMP-1152] Code refactoring for s3AndKinesis PTransform #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ptal (👀) @premsantosh @glaksh100 |
premsantosh
approved these changes
Nov 30, 2020
| builder = builder.withLatenessInSec(latenessInSec.asLong()); | ||
| JsonNode maxOutOfOrdernessMillis = node.get("max_out_of_orderness_millis"); | ||
| if (maxOutOfOrdernessMillis != null) { | ||
| builder = builder.withLatenessInSec(maxOutOfOrdernessMillis.asLong()/1000); |
There was a problem hiding this comment.
Lets just add a TODO here to change the builder method name later as well.
There was a problem hiding this comment.
I made the change to avoid tripping off Beam users. One is developer friendly and the other is streaming pro friendly :) Added a TODO for now.
...link/src/main/java/org/apache/beam/runners/flink/LyftFlinkStreamingPortableTranslations.java
Show resolved
Hide resolved
maghamravi
added a commit
that referenced
this pull request
Dec 1, 2020
maghamravi
added a commit
that referenced
this pull request
Dec 1, 2020
maghamravi
added a commit
that referenced
this pull request
Dec 1, 2020
nji302
pushed a commit
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring s3AndKinesis PTransform.
namedtupleand using classes.