Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation instructions to README #9

Merged
merged 3 commits into from Apr 14, 2018
Merged

Add installation instructions to README #9

merged 3 commits into from Apr 14, 2018

Conversation

sunshinejr
Copy link
Contributor

Hey guys! This one is to help people that do not know how to install python libs. I'm not an expert myself so let me know if these are good enough.

@keith keith requested a review from ikonst February 18, 2018 18:23
README.md Outdated

Using `pip`:
```
pip install git+https://github.com/lyft/xiblint.git
Copy link
Contributor

@ikonst ikonst Feb 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The releases are in pypi, so you should just pip install xiblint.

README.md Outdated
Manual:
```
git clone https://github.com/lyft/xiblint.git
cd xiblint && sudo python setup.py install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep out the sudo

Copy link
Contributor

@ikonst ikonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@sunshinejr
Copy link
Contributor Author

Sorry for the delay @ikonst, fixed the PR. Let me know how it looks.

@keith keith merged commit 77952fe into lyft:master Apr 14, 2018
@sunshinejr sunshinejr deleted the add_installation_step branch April 14, 2018 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants