Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation instructions to README #9

Merged
merged 3 commits into from Apr 14, 2018

Conversation

@sunshinejr
Copy link
Contributor

@sunshinejr sunshinejr commented Feb 18, 2018

Hey guys! This one is to help people that do not know how to install python libs. I'm not an expert myself so let me know if these are good enough.

@keith keith requested a review from ikonst Feb 18, 2018
README.md Outdated

Using `pip`:
```
pip install git+https://github.com/lyft/xiblint.git

This comment has been minimized.

@ikonst

ikonst Feb 18, 2018
Contributor

The releases are in pypi, so you should just pip install xiblint.

README.md Outdated
Manual:
```
git clone https://github.com/lyft/xiblint.git
cd xiblint && sudo python setup.py install

This comment has been minimized.

@ikonst

ikonst Feb 18, 2018
Contributor

Keep out the sudo

Copy link
Contributor

@ikonst ikonst left a comment

See comments.

@sunshinejr
Copy link
Contributor Author

@sunshinejr sunshinejr commented Mar 18, 2018

Sorry for the delay @ikonst, fixed the PR. Let me know how it looks.

@ikonst
ikonst approved these changes Mar 19, 2018
@keith keith merged commit 77952fe into lyft:master Apr 14, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sunshinejr sunshinejr deleted the sunshinejr:add_installation_step branch Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants