New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to set video time base before pushing packets. #1109

Merged
merged 1 commit into from Jan 4, 2018

Conversation

Projects
None yet
2 participants
@yannistseng
Contributor

yannistseng commented Jan 3, 2018

  • Fixed recordings could not be generated before stopping recording.

Description

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

yannis.tseng
Need to set video time base before push packets.
- Fixed recordings could not be generated before stopping recording.

@yannistseng yannistseng changed the title from Need to set video time base before push packets. to Need to set video time base before pushing packets. Jan 3, 2018

@jcague

jcague approved these changes Jan 4, 2018

LGTM! good catch!

@jcague jcague merged commit 29663a5 into lynckia:master Jan 4, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment