Add support for /dev/nvmeX NVMe controllers #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added nvme scanning for controllers /dev/nvme[0-9]+ * Added nvme scanning for namespaces /dev/nvme[0-9]+n[0-9]+ * Fill in namespaces as disks * Teach partition scanning about nvme partitions /dev/nvme[0-9]+n[0-9]+p[0-9]+
hjmallon
changed the title
hjmallon
changed the title
|
Is there anything I can do to this pull request to move it forwards? |
|
I'm closing this, comments and follow up to happen on the Pull Request at exiz.org linked above. |
lyonel
added a commit
that referenced
this pull request
Oct 13, 2021
…is' (#45) from alexhenrie/lshw:punctuation into master Reviewed-on: https://ezix.org/src/pkg/lshw/pulls/45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea what else would need to be added for this?
I think this might solve https://ezix.org/project/ticket/752
The NVMe devices I am testing with are PCI-e attached. Each NVMe device can have multiple namespaces (which appear as block devices). Does the layout I have gone for makes sense?
I have not got any more complex NVMe devices to test with, e.g. enterprise level NVMe-over-Fabrics or attached over SAS cables. That will have to come later (if anyone is interested).
All feedback / request for changes welcomed. This is marked as
WIPuntil I can answer the above questions.