Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds basic styling and semantic UI to the deleted logs. #19

Merged
merged 3 commits into from
Oct 3, 2022

Conversation

Lofty-Brambles
Copy link
Contributor

This fixes issue #5

@vercel
Copy link

vercel bot commented Oct 2, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @lyqht on Vercel.

@lyqht first needs to authorize it.

@lyqht
Copy link
Owner

lyqht commented Oct 2, 2022

Screenshot of what I can see as of this commit - Looks good.

image

Some feedback

  1. I realized why the daisyui table styles are not applied is because we didn't add the layouts folder to the tailwind.config.js.
    So could you add a line to tailwind.config.js
  content: [
    './src/pages/**/*.{js,ts,jsx,tsx}',
    './src/components/**/*.{js,ts,jsx,tsx}',
    './src/features/**/*.{js,ts,jsx,tsx}',
    './src/layouts/**/*.{js,ts,jsx,tsx}', // this line
  ],

After which you should see

image

  1. I prefer the column names to be normal text than some Unicode characters. If possible, could u amend it to normal text characters and then apply classnames to make it look nicer if that's the intent?

Thanks for working on this!

Fixes the issue with configuration of Daisy UI and tailwind, styles History-logs.tsx

fix lyqht#19
@vercel
Copy link

vercel bot commented Oct 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
octokit-lite ✅ Ready (Inspect) Visit Preview Oct 3, 2022 at 1:46AM (UTC)

@lyqht
Copy link
Owner

lyqht commented Oct 3, 2022

Screenshot

image

Great stuff!

@lyqht lyqht merged commit 0b6cf5c into lyqht:main Oct 3, 2022
@lyqht lyqht self-assigned this Oct 19, 2022
@lyqht lyqht removed their assignment Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants