New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent bugfix breaks image preview for direct links #584

Closed
Volvagia356 opened this Issue Jul 29, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@Volvagia356
Copy link
Collaborator

Volvagia356 commented Jul 29, 2015

The recent bugfix changes how URL parsing works, and it appears to have broken image preview for direct links to images.

@Volvagia356 Volvagia356 self-assigned this Jul 29, 2015

Volvagia356 added a commit to Volvagia356/Hotot that referenced this issue Aug 12, 2015

Fix lyricat#584. Read image preview URLs from entities
Previously, the code that generates image previews reads URLs from the
tweet body text. This worked before as the t.co URLs were expanded
before image previews are processed. However, the t.co expansion code
was moved to after the image preview code in a previous bugfix, breaking
the image preview functionality for URLs.

To fix this, the image preview code now reads the URLs directly from the
entities provided by Twitter, instead of reading it from tweet body.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment