Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If input is received from stdin, output the unmodified value to stdout. #221

Merged
merged 2 commits into from Sep 15, 2022
Merged

If input is received from stdin, output the unmodified value to stdout. #221

merged 2 commits into from Sep 15, 2022

Conversation

ghost
Copy link

@ghost ghost commented Sep 14, 2022

Checklist

  • Add test cases to all the changes you introduce

Not sure if it is possible to provide a test for this sort of behavior:

            # Click testing runner doesn't simulate correctly the reading from stdin
            # instead of setting the name attribute to `<stdin>` it gives an
            # AttributeError. But when you use it outside testing, no AttributeError
            # is raised and name has the value <stdin>. So there is no way of testing
            # this behaviour.
  • Update the documentation for the changes

Correct behavior is already documented in

If the input is taken from stdin, it will output the value to stdout.

@coveralls
Copy link

coveralls commented Sep 15, 2022

Pull Request Test Coverage Report for Build 3056895311

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.25%

Totals Coverage Status
Change from base Build 2690162637: 0.0%
Covered Lines: 308
Relevant Lines: 320

💛 - Coveralls

Copy link
Owner

@lyz-code lyz-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution :)

@lyz-code lyz-code merged commit e156dec into lyz-code:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants