Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need some treating to 'inline' ("streaming" branch) #5

Closed
t-mat opened this issue May 24, 2014 · 2 comments
Closed

Need some treating to 'inline' ("streaming" branch) #5

t-mat opened this issue May 24, 2014 · 2 comments

Comments

@t-mat
Copy link
Contributor

@t-mat t-mat commented May 24, 2014

(1) In streaming branch, MSVC 2012 and 2013 show the following errors :

lz4.c(658): error C2054: expected '(' to follow 'inline'
lz4.c(822): error C2054: expected '(' to follow 'inline'

(2) Other branches have FORCE_INLINE macro, but it is omitted in stream branch. Maybe for simplification.

(3) It seems to me we have 2 options to solve this problem.

  • (A) : Define inline macro for MSVC.
  • (B) : Redefine FORCE_INLINE macro and use it.

But since inline is keyword in C99 and C++98, I think using FORCE_INLINE is verifed and better solution.

@Cyan4973
Copy link
Member

@Cyan4973 Cyan4973 commented May 24, 2014

You are totally right Takayuki. The streaming branch is currently experiencing some major change. I was expecting to only have a serious look at inline when code starts to settle a bit. Sorry for inconvenience during intermediate releases.
My current dev environment is gcc on Linux, Visual is only used as a second choice, mostly for verification.

@t-mat
Copy link
Contributor Author

@t-mat t-mat commented May 24, 2014

I see. Thanks for the clarification !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants