Backport: fixed integer value auto completer #121 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am backporting this patch wvanbergen#121 into 2.7.1 for the record. |
|
@abenari any chance you can have a look? thanks! |
|
Lgtm |
|
@abenari any idea about the failing tests? |
|
@ohadlevy, tests seems to fail due to an environment issue "failed to install pg". |
|
Thanks for investigation, can you please create stable-2.7.1 branch upstream so I can open the PR there and fix the tests? Thanks! |
|
@lzap We have a tag for each version, you can open a pull request on tag v2.7.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - tests via Travis CI