Skip to content

/PSReadLine

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PSReadLine more portable #561

Merged
merged 65 commits into from Oct 16, 2017
+3,929 −2,710

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@lzybkr @jsoref @xiaoyinl @andschwa @oising @palladia @PaulHigin
@lzybkr
Copy link
Owner

lzybkr commented Oct 16, 2017

All of the changes from PowerShell/PowerShell have been integrated or redone.

All rendering is now down with ANSI escape sequences and the core rendering no longer uses Windows specific data structures or apis.

Custom key binding code was rewritten in an attempt to accommodate platform differences, but we still need some P/Invokes on Windows, t.b.d. on Linux.

The PR includes a few internationalization fixes - cursor placement for CJK, plus improved handling of key bindings for less common keyboard layouts.

One new feature in this PR - tooltips are always displayed unless they don't add anything useful (same as the completion). They are only displayed below the menu instead of the old style which truncated the tooltip.

lzybkr added some commits Aug 1, 2017

@lzybkr
Basic ANSI escapes working
691c6b1
@lzybkr
Fix rendering of selected text
72fdf86
@lzybkr
Use correct continuation prompt background color
103ec35
@lzybkr
Support ansi escapes in unit test mock console
de87cef
@lzybkr
Move to .Net 4.6.1 in prep for .Net Standard 2.0
54545d6
@lzybkr
Properly clear buffer in unit tests that reuse console
8a0d05f
@lzybkr
Reset previous render before reading a line
575a10d
@lzybkr
Use correct color when overwriting with spaces 
Mostly to keep tests happy.
d9ec61d
@lzybkr
Define and use prompt in test host
e93b1e5
@lzybkr
Get red prompt working again 
With no portable way to scrape, displaying red in the prompt is harder.

To start, there is a new option to specify the end of the prompt text so
you can specify exactly what should turn red.

Many folks won't use this, so there are some smarts added at startup to
analyze the prompt function - if it's "pure", as in, doesn't call any
methods or commands, we call it and infer the invariant part of the
prompt, basically the last non-whitespace character plus the trailing
whitespace.
ef1bb9b
@lzybkr
Fix InvokePrompt
6ecbd09
@lzybkr
Add Test overloads to ease analysis of tests
ed2ca79
@lzybkr
Add basic support for custom colors 
Colors can now be customized using RGB (like #RRGGBB) or with escape
sequences.
138b226
@lzybkr
Merge Foreground/Background options 
Fix selection to use escape sequence for invert - it doesn't look that
great when there are too many colors, but it will work with any
customization.

Also fix tests to work after previous commit.
de5d7bd
@lzybkr
Remove unreferenced methods
11fca62
@lzybkr
PossibleCompletions fixed, all tests passing
820e423
@lzybkr
MenuComplete mostly working
4d67c6b
@lzybkr
Require PowerShell V5
e32582a
@lzybkr
MenuComplete filtering working now
66d34c6
@lzybkr
Moving onwards towards minimal P/Invokes
96772e4
@lzybkr
Fix auto-prompt analysis to cover more cases
e4a529a
@lzybkr
Bump version to 2.0
8550dad
@lzybkr
Update change log
e53cc84
@lzybkr
Introduce runtime check of platform 
In the move to producing a single binary for a protable module, we'll
need some runtime checks - so I've add a single one which also requires
a dependency on new NuGet package.
Loading status checks…
837921a
@lzybkr
Fix rendering artifacts from shorter renders
e2fb174
@lzybkr
Fix completion at bottom of buffer
Loading status checks…
8453d4c
@lzybkr
Specify Platform=AnyCPU for build automation
Loading status checks…
3aadd54
@lzybkr
Add .vs directory to .gitignore
1104eb0
@lzybkr
More end of buffer rendering fixes
Loading status checks…
ad7d580
@lzybkr
More menu rendering at end of buffer fixes
Loading status checks…
756d764

lzybkr added some commits Sep 5, 2017

@lzybkr
Update sln for VS2017
Loading status checks…
6b0547c
@lzybkr
Show tooltips by default in MenuComplete
Loading status checks…
fb10c6d
@lzybkr
Fix WhatIsKey/ShowKeyBindings
9374839
@lzybkr
Fix some rendering issues
Loading status checks…
9e39cf0
@lzybkr
Use Unicode OuputEncoding for rendering
Loading status checks…
8edcf64
@lzybkr
Portable custom key bindings 
Rewrote the custom key binding code to be more portable.

Some runtime checks are necessary because of impossible to reconcile
differences.

Some Win32 P/Invoke calls are still needed due to lack of information in
the ConsoleKeyInfo.

Some keys are currently not available on Linux due to a CLR bug, others
aren't available ever because terminals don't unique character sequences
for a given key press that might differ in just the Shift or Ctrl state.
Loading status checks…
63d2dcf
@lzybkr
Fix Beep on Linux to use implemented api
Loading status checks…
42d5210
@lzybkr
Escape escapes in Get-PSReadLineOption output
Loading status checks…
69d8074
@lzybkr
Update Changes.txt
Loading status checks…
68e4038

@lzybkr lzybkr referenced this pull request Oct 16, 2017

Closed

Import PowerShell changes #442

@lzybkr lzybkr merged commit 9d592b8 into master Oct 16, 2017
2 checks passed

2 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

This was referenced Oct 16, 2017

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed

This was referenced Oct 31, 2017

Closed
Open
Open
Open
Closed
Closed

@lzybkr lzybkr deleted the ansi_render branch Nov 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.