Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable this addon for devtools also when the addon is disabled on page. #64

Closed
vijaykm2 opened this issue Feb 9, 2017 · 3 comments
Closed
Assignees

Comments

@vijaykm2
Copy link

@vijaykm2 vijaykm2 commented Feb 9, 2017

I have been using this addon for many months and it like it very much. Only issue I found is:
When the addon is disabled on page, it is not completely disabled in devtools also. For example in the attached screenshot, it is not disabled in devtools menubar and also in react tab. Devtools menubar has a light theme but it is dark.

I am using Nightly in OSX.
screen shot 2017-02-08 at 9 51 48 pm

@m-khvoinitsky
Copy link
Owner

@m-khvoinitsky m-khvoinitsky commented Feb 9, 2017

Devtools is not a part of a page. It's a separate "page". It should be possible to configure it too, there is an issue for that - #10. However, in particular with devtools it work a bit different: devtools have a few built-in themes: dark, light and FireBug-like. My add-on forces enabling of dark variant. That's actually should be configurabe.

@dhrv
Copy link

@dhrv dhrv commented Feb 20, 2017

My add-on forces enabling of dark variant. That's actually should be configurabe.

Yes, please make this configurable and/or don't force the dark theme. Thank you!

@m-khvoinitsky m-khvoinitsky self-assigned this May 22, 2017
@m-khvoinitsky
Copy link
Owner

@m-khvoinitsky m-khvoinitsky commented May 24, 2017

Well, I've misunderstood you a bit.
About the react tab - it's not built in firefox but a separate extension so it doesn't use firefox devtools theme — #10 is the case. Until then you can open resource://react-devtools/data/ in a regular tab and disable the add-on for this url.
About the devtools tab/menu bar — fixed in 2eea9de
bq. My add-on forces enabling of dark variant. That's actually should be configurabe.
I'm going to remove this feature because it will be impossible to implement it with WebExtensions. Anyway, most users use default theme which is not depends on devtools theme while advanced users can choose appropriate devtools theme or Firefox' "Compact Dark". UPD: 89a0ad4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants