Hardcode AF_INET for windows ndt7-client builds #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfr10598
approved these changes
Sep 23, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 LGTMs obtained
stephen-soltesz
added a commit
to m-lab/ndt7-client-go
that referenced
this pull request
Sep 23, 2020
stephen-soltesz
added a commit
to m-lab/ndt7-client-go
that referenced
this pull request
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes m-lab/ndt7-client-go#50 by removing references to
unix.AF_INETand replacing it with a simple constant. This value has not changed in the Linux sources since before Linux v1.0. Since AF_INET6 is also hard-coded and we only want Linux-related values here, I believe this is a safe change and allows non-Linux clients to build.This change is