Skip to content

Commit

Permalink
hp-wmi: Enable hotkeys on some systems
Browse files Browse the repository at this point in the history
Kyle Evans discovered that he needed to set some bits in an EC register in
order to receive hotkey events. Doing so blindly broke some otherwise
working HP laptops. It turns out that there's a WMI call that accesses
the same register, so let's try calling that instead.

Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
Cc: Kyle Evans <kvans32@gmail.com>
  • Loading branch information
Matthew Garrett committed Jul 8, 2013
1 parent d2b4a64 commit b253c9d
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions drivers/platform/x86/hp-wmi.c
Expand Up @@ -53,6 +53,7 @@ MODULE_ALIAS("wmi:5FB7F034-2C63-45e9-BE91-3D44E2C707E4");
#define HPWMI_ALS_QUERY 0x3
#define HPWMI_HARDWARE_QUERY 0x4
#define HPWMI_WIRELESS_QUERY 0x5
#define HPWMI_BIOS_QUERY 0x9
#define HPWMI_HOTKEY_QUERY 0xc
#define HPWMI_WIRELESS2_QUERY 0x1b

Expand Down Expand Up @@ -291,6 +292,19 @@ static int hp_wmi_tablet_state(void)
return (state & 0x4) ? 1 : 0;
}

static int hp_wmi_enable_hotkeys(void)
{
int ret;
int query = 0x6e;

ret = hp_wmi_perform_query(HPWMI_BIOS_QUERY, 1, &query, sizeof(query),
0);

if (ret)
return -EINVAL;
return 0;
}

static int hp_wmi_set_block(void *data, bool blocked)
{
enum hp_wmi_radio r = (enum hp_wmi_radio) data;
Expand Down Expand Up @@ -948,6 +962,8 @@ static int __init hp_wmi_init(void)
err = hp_wmi_input_setup();
if (err)
return err;

hp_wmi_enable_hotkeys();
}

if (bios_capable) {
Expand Down

0 comments on commit b253c9d

Please sign in to comment.