Makefile: fix install, add include path for debian #5

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@peteut
Contributor

peteut commented Sep 2, 2012

Fixes missed include (-I) and install if the target directory is not yet created.

@sbourdeauducq

This comment has been minimized.

Show comment Hide comment
@sbourdeauducq

sbourdeauducq Sep 9, 2012

I think INSTDIR should be created by the Icarus Verilog package. If it does not exist, it probably means that the value of INSTDIR is wrong and it makes more sense to fail in this case rather than installing the module into some random location in the filesystem only to spend time later figuring out why Iverilog does not find the module.
Or am I missing something?

I think INSTDIR should be created by the Icarus Verilog package. If it does not exist, it probably means that the value of INSTDIR is wrong and it makes more sense to fail in this case rather than installing the module into some random location in the filesystem only to spend time later figuring out why Iverilog does not find the module.
Or am I missing something?

This comment has been minimized.

Show comment Hide comment
@peteut

peteut Sep 9, 2012

Owner

Understand. I'll remove that in this case. In Debian it should be valid (locally stuff shall be located under /usr/local/).

Owner

peteut replied Sep 9, 2012

Understand. I'll remove that in this case. In Debian it should be valid (locally stuff shall be located under /usr/local/).

@sbourdeauducq

This comment has been minimized.

Show comment Hide comment
@sbourdeauducq

sbourdeauducq Sep 9, 2012

Ok to have this one in the default include paths.

Ok to have this one in the default include paths.

@sbourdeauducq

This comment has been minimized.

Show comment Hide comment
@sbourdeauducq

sbourdeauducq Sep 9, 2012

This will break if multiple include directories are specified. Make has a $(prefix...) function that should be used here.
Also, the documentation (doc/simulation.rst) needs updating.

This will break if multiple include directories are specified. Make has a $(prefix...) function that should be used here.
Also, the documentation (doc/simulation.rst) needs updating.

This comment has been minimized.

Show comment Hide comment
@peteut

peteut Sep 9, 2012

Owner

I've overseen that, your're completely right. I'll update that accordingly.

Owner

peteut replied Sep 9, 2012

I've overseen that, your're completely right. I'll update that accordingly.

@peteut peteut deleted the peteut:fix_vpi_makefile branch Apr 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment