Bump openid_connect dependency #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Jan 4, 2019
|
Thanks a lot @gregmolnar! |
|
@m0n9oose you're welcom. Is there any chance to cut a new release? |
|
@gregmolnar there's two more interesting PRs. I wanna try merge them too and then release new version |
Hey @gregmolnar I have released new version 0.2.4 Let me know if you have any feedback on this release |
|
@m0n9oose Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I set the
openid_connectdependency to a more recent version. We are using a fork of this gem with that change without any issues. I'd also setup travis, but you will need to enable it for this repo here:https://travis-ci.org/m0n9oose/omniauth_openid_connect
The build is passing on my fork: https://travis-ci.org/gregmolnar/omniauth_openid_connect
/cc @m0n9oose
closes #3