New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support :extra-values for specific target paths #22

Closed
gambhiro opened this Issue Oct 30, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@gambhiro

gambhiro commented Oct 30, 2016

This is for the case where you want to render the templates with different variables based on the target path, to allow using some view-logic say, for a dev and prod output.

As in #1, but allowing for :extra-values to be passed with each path:

  :resource {:resource-paths [["resources"
                               {:target-path "app/dev"
                                :extra-values {:dev true :prod false}}]
                              ["resources"
                               {:target-path "app/prod"
                                :extra-values {:dev false :prod true}}]]}
@m0smith

This comment has been minimized.

Show comment
Hide comment
@m0smith

m0smith Nov 6, 2016

Owner

Try pulling the branch feature/gh-22-support-extra-values-in-resource and installing it and seeing if it does what you want

Owner

m0smith commented Nov 6, 2016

Try pulling the branch feature/gh-22-support-extra-values-in-resource and installing it and seeing if it does what you want

@gambhiro

This comment has been minimized.

Show comment
Hide comment
@gambhiro

gambhiro Nov 7, 2016

Beautiful! It works great, many thanks.

gambhiro commented Nov 7, 2016

Beautiful! It works great, many thanks.

@gambhiro gambhiro closed this Nov 7, 2016

m0smith pushed a commit that referenced this issue Nov 7, 2016

Matthew O. Smith

m0smith pushed a commit that referenced this issue Nov 7, 2016

Matthew O. Smith

m0smith added a commit that referenced this issue Nov 7, 2016

Feature/gh 22 support extra values in resource (#23)
*  gh-22 start testing extra-values in resource path

*  gh-22 unit tests for extra value map in resource path

*  gh-22 added testing at the top level

*  updated version

* gh-22 update docs and version

*  gh-12 Adapt unit test to run on Windows
@m0smith

This comment has been minimized.

Show comment
Hide comment
@m0smith

m0smith Nov 7, 2016

Owner

Released in version 16.11.1

Owner

m0smith commented Nov 7, 2016

Released in version 16.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment