ignore server message; handle SIGTERM #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Conflict with master branch? |
Ignore all messages received without an username, this type of messages is often used in system notice and should be ignored. Especially, some servers with mandatory OTR requirement send an error if a non-OTR message is received, if we reply these automatic messages with an automatic response, an infinite loop could start and exhaust all system resources. Signed-off-by: Yifeng Li <tomli@tomli.me>
When using chatlist as a system daemon, a SIGTERM signal is used by the daemon manager to stop a daemon, but it's not handled in chatlist and causes chatlist to quit immediately without closing connection or saving data. This commit adds a signal handler to call sys.exit() if SIGTERM is received, effectively converting a SIGTERM to a SystemExit exception. Signed-off-by: Yifeng Li <tomli@tomli.me>
|
Merge conflict is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yifeng Li <tomli@tomli.me>
Signed-off-by: Yifeng Li <tomli@tomli.me>