Skip to content

Changes: #16

Open
wants to merge 1 commit into from

2 participants

@chetmurthy

(1) added some command-line args for the mysql backend, to specify
host, user, pass, database

(2) build options for specifying leveldb, snappy, bdb, etc

(3) added a "metadata" method that returns server metadata to the
client. THis was in order to change the sample client so that it
wouldn't fail on leveldb (which always returns success on deletes)

@chetmurthy chetmurthy Changes:
(1) added some command-line args for the mysql backend, to specify
host, user, pass, database

(2) build options for specifying leveldb, snappy, bdb, etc

(3) added a "metadata" method that returns server metadata to the
client.  THis was in order to change the sample client so that it
wouldn't fail on leveldb (which always returns success on deletes)
54a0853
@m1ch1
Owner

These variables shouldn't refer to /home/chet. Instead, the default values should correspond to the build instructions:

https://github.com/m1ch1/mapkeeper/blob/master/bdb/README.md
https://github.com/m1ch1/mapkeeper/blob/master/kyotocabinet/README.md
https://github.com/m1ch1/mapkeeper/blob/master/mysql/README.md

I'd rather not include MAVEN_DIR, and leave it up to the users to set PATH correctly.

What's snappy?

@m1ch1
Owner

It's probably better not to include the versions, since the specific version might not be available on the host system.

@m1ch1
Owner

Did you need this header to compile?

@m1ch1

Looks like this block is indented incorrectly.

@m1ch1

Some headers are included twice.

@m1ch1

We can probably delete this line.

@m1ch1

Indentation?

@m1ch1

Indentation?

@m1ch1

Do we need this change?

@m1ch1

Indentation?

@m1ch1

We don't need to check for verbose flag here.

@m1ch1

I prefer the name getMetadata() to be consistent with other methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.