Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update namespace_configuration docs to use the right keys #2045

Merged
merged 6 commits into from Nov 26, 2019

Conversation

@bpownow
Copy link
Contributor

bpownow commented Nov 15, 2019

What this PR does / why we need it:

Fixes #

Does this PR introduce a user-facing and/or backwards incompatible change?: No


Does this PR require updating code package or user-facing documentation?: This is a documentation update.


@bpownow bpownow changed the title Update namespace_configuration.md update namespace_configuration docs Nov 15, 2019
@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Nov 15, 2019

CLA assistant check
All committers have signed the CLA.

@bpownow bpownow changed the title update namespace_configuration docs update namespace_configuration docs to use the right keys Nov 15, 2019
"blockDataExpiry": true,
"blockDataExpiryAfterNotAccessPeriodDuration": "5m"
"blockDataExpiryAfterNotAccessPeriod": "5m"

This comment has been minimized.

Copy link
@arnikola

arnikola Nov 25, 2019

Collaborator

This may have to be blockDataExpiryAfterNotAccessedPeriod as here

This comment has been minimized.

Copy link
@bpownow

bpownow Nov 25, 2019

Author Contributor

@arnikola updated

@arnikola arnikola added the ci label Nov 25, 2019
@schallert schallert removed the ci label Nov 25, 2019
@bpownow

This comment has been minimized.

Copy link
Contributor Author

bpownow commented Nov 26, 2019

@arnikola Can we merge this?

@arnikola

This comment has been minimized.

Copy link
Collaborator

arnikola commented Nov 26, 2019

Yeah sorry, new stuff keeps coming in before I get a chance to merge :p

@arnikola arnikola merged commit 6f2ecf5 into m3db:master Nov 26, 2019
4 checks passed
4 checks passed
buildkite/m3/pr Build #1128 passed (18 minutes, 20 seconds)
Details
ci-gate Pull Request accepted for CI
license/cla Contributor License Agreement is signed.
Details
netlify/m3db/deploy-preview Deploy preview ready!
Details
@arnikola

This comment has been minimized.

Copy link
Collaborator

arnikola commented Nov 26, 2019

Thanks again, merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.