Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue promoting unsigned values on the evaluation stack. #822

Merged
merged 1 commit into from Jul 22, 2022

Conversation

MoFtZ
Copy link
Collaborator

@MoFtZ MoFtZ commented Jun 24, 2022

Fixes #819.

Also removed the unused/obsolete flags ConvertFlags.Overflow and ConvertFlags.OverflowSourceUnsigned.

This PR depends on #820 to reset the compatibility suppression files.

@MoFtZ MoFtZ added the bug label Jun 24, 2022
@MoFtZ MoFtZ force-pushed the bug/unsigned-promotion branch 2 times, most recently from 3015bcb to 4f99fd9 Compare June 30, 2022 21:03
@MoFtZ MoFtZ marked this pull request as ready for review June 30, 2022 22:00
Copy link
Owner

@m4rs-mt m4rs-mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this patch 🥇

@m4rs-mt m4rs-mt added this to the v1.3 milestone Jul 22, 2022
@m4rs-mt m4rs-mt merged commit ca45ebf into m4rs-mt:master Jul 22, 2022
@MoFtZ MoFtZ deleted the bug/unsigned-promotion branch August 25, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit conversion operation does not correctly handle unsigned values.
2 participants