Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not work with CRNA / Expo #50

Closed
Morriz opened this issue Sep 28, 2017 · 12 comments
Closed

does not work with CRNA / Expo #50

Morriz opened this issue Sep 28, 2017 · 12 comments

Comments

@Morriz
Copy link

Morriz commented Sep 28, 2017

Hi, any idea why I can't seem to import your module with a fresh CRNA install?

import SInfo from 'react-native-sensitive-info'

console.log('SInfo: ', SInfo)

console output:
SInfo: undefined

I use:

"dependencies": {
    "expo": "^21.0.0",
    "react": "16.0.0-alpha.12",
    "react-native": "^0.48.4",
    "react-native-sensitive-info": "^5.1.0"
  }
@vspedr
Copy link
Contributor

vspedr commented Sep 28, 2017

Hi @Morriz! Did you get this behavior on Android or iOS? Usually when a module with native code returns undefined it's because it was not linked properly with the native projects, you can try running react-native link react-native-sensitive-info again or linking it manually. I'm not very familiar with expo though, not sure how it handles external native dependencies.

@Morriz
Copy link
Author

Morriz commented Sep 28, 2017 via email

@Morriz
Copy link
Author

Morriz commented Sep 28, 2017 via email

@vspedr
Copy link
Contributor

vspedr commented Sep 28, 2017

Yes, that would be nice given the popularity of CRNA. I will look into it this weekend, maybe @mCodex can give it a try too

@mCodex
Copy link
Owner

mCodex commented Oct 4, 2017

@Morriz thank you for letting us know about this problem. I'll take a look :)

@Morriz
Copy link
Author

Morriz commented Oct 5, 2017 via email

@Palisand
Copy link

Palisand commented Oct 5, 2017

@mCodex @Morriz

You cannot use any modules that require linking (i.e. native modules) with expo. This is not an issue with react-native-sensitive-info. You must either detach to ExpoKit or eject completely. See this.

Please note that Expo SDK 21 already has a SecureStore.

@vspedr
Copy link
Contributor

vspedr commented Oct 5, 2017

Thanks for clarifying @Palisand!

@Morriz
Copy link
Author

Morriz commented Oct 6, 2017 via email

@mCodex
Copy link
Owner

mCodex commented Oct 10, 2017

Thanks @Palisand 👍 I'll close this issue for now since @Morriz found the solution 👍

@marudhupandiyang
Copy link

marudhupandiyang commented Sep 3, 2018

I encountered the same issue with react-native init project on ios. The auto linking did not work. I had to manually link to get this working. My project is not using 'pods'

@vspedr
Copy link
Contributor

vspedr commented Sep 3, 2018

@marudhupandiyang could you please open a new issue for that and provide more detail (RN version, iOS version etc.)?

Repository owner locked as resolved and limited conversation to collaborators Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants