Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for data URIs. #16
Conversation
wafflebot
bot
assigned
sstanovnik
Apr 4, 2019
wafflebot
bot
added
the
demo
label
Apr 4, 2019
sstanovnik
requested a review
from
rsucasas
Apr 4, 2019
sstanovnik
assigned
rsucasas
Apr 4, 2019
rsucasas
merged commit 7c35892
into
master
Apr 4, 2019
wafflebot
bot
removed
the
demo
label
Apr 4, 2019
sstanovnik
deleted the
datauri
branch
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sstanovnik commentedApr 4, 2019
This adds support for
data:URIs, which simplify my usage of the lifecycle manager. Thewgetlibrary does not support them (and is unmaintained in general), so I've removed its only usage and used what Python 3.4+ provides out of the box.