Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clipping rect when rasterizing to limit image dimensions at sane values #25

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@manuelbua
Copy link

commented Jun 15, 2019

Under some circumstances, the output image can be resized indefinitely by the rasterizer while processing the webpage. For example, the Yahoo homepage can result in an image of size 1200x5000+, some other pages can result in images of size 1200x31000 and a 15.4Mb jpg!

The proposed change is to allow for a maximum of 2x multiplier on the specified/default viewport size: that is, the final image will never be bigger than 1200x1600 with the default configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.