New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on running with no power cable / removing power cable #42

Closed
kiaroa opened this Issue Apr 21, 2017 · 4 comments

Comments

2 participants
@kiaroa

kiaroa commented Apr 21, 2017

Running ubuntu 17.04 zesty.

With power cable in, it starts fine, then correctly shows time to full charge.

If started with power cable out, or cable is removed after starting I get this:

Traceback (most recent call last):
  File "/usr/share/battery-monitor/battery-monitor.py", line 197, in <module>
    notification.show_specific_notifications(monitor)
  File "/usr/share/battery-monitor/battery-monitor.py", line 145, in show_specific_notifications
    elif percentage == int(self.first_custom_warning):
ValueError: invalid literal for int() with base 10: ''

(process:24772): GLib-GObject-WARNING **: ../../../../gobject/gsignal.c:2641: instance '0x55fb26e680a0' has no handler with id '7'

@maateen maateen added the bug label Apr 21, 2017

@kiaroa

This comment has been minimized.

Show comment
Hide comment
@kiaroa

kiaroa Apr 24, 2017

Pobably missing values, line 78. I've inserted these values, and error seems resolved:
self.first_custom_warning = '25'
self.second_custom_warning = '20'
self.third_custom_warning = '15'

kiaroa commented Apr 24, 2017

Pobably missing values, line 78. I've inserted these values, and error seems resolved:
self.first_custom_warning = '25'
self.second_custom_warning = '20'
self.third_custom_warning = '15'

@maateen

This comment has been minimized.

Show comment
Hide comment
@maateen

maateen Apr 24, 2017

Owner

I'm gonna fix the bug soon. Also I'll introduce automated testing to make the project bug free in near future.

Owner

maateen commented Apr 24, 2017

I'm gonna fix the bug soon. Also I'll introduce automated testing to make the project bug free in near future.

@maateen

This comment has been minimized.

Show comment
Hide comment
@maateen

maateen Apr 24, 2017

Owner

I can remember that once I've fixed it but somehow I haven't pushed that code to upstream.

Owner

maateen commented Apr 24, 2017

I can remember that once I've fixed it but somehow I haven't pushed that code to upstream.

@maateen

This comment has been minimized.

Show comment
Hide comment
@maateen

maateen Apr 25, 2017

Owner

@kiaroa I have pushed a new commit to devel branch. This should fix your issue. Though I haven't merged this with master branch, but you can test this from here. Please let me know the updates.

Owner

maateen commented Apr 25, 2017

@kiaroa I have pushed a new commit to devel branch. This should fix your issue. Though I haven't merged this with master branch, but you can test this from here. Please let me know the updates.

@maateen maateen closed this in e8733cb Apr 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment