Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added building as library (shared and static) #15

Merged
merged 1 commit into from
Mar 18, 2017
Merged

Conversation

doe300
Copy link
Contributor

@doe300 doe300 commented Mar 15, 2017

This extends the Makefile to build the vc4asm as shared and static library into the lib/ folder to be used in other projects

@maazl
Copy link
Owner

maazl commented Mar 18, 2017

I am still working on the cmake migration, so the library has to be ported to cmake as well. However, the change should not cause much harm.

Unfortunately some hard coded properties of cmake make it really hard to build partially cross platform from the same source directory, i.e. the assembler can build on any platform while the sample binaries are in fact restricted to Raspberry Pi, which in fact are three platforms for now (ARMV6, ARMV7 and ARM64).

@maazl maazl merged commit 96f2964 into maazl:master Mar 18, 2017
@doe300
Copy link
Contributor Author

doe300 commented Mar 18, 2017

A cmake build-script would be great.

Could'n you just add a check to cmake, so the sample-binaries are only built, if the architecture is a Raspberry Pi (or the code is built with a Raspberry Pi cross-compiler)?

@maazl
Copy link
Owner

maazl commented Mar 18, 2017 via email

@ilovezfs
Copy link

The changes made here have broken the build on macOS. See #18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants