Permalink
Commits on Nov 30, 2011
  1. Small UI change to zones.

    Mauro Botelho
    Mauro Botelho committed Nov 30, 2011
  2. Add shorter helper method for opening the page

    radar authored and Mauro Botelho committed Nov 30, 2011
  3. Use routing helpers rather than via for cart routes

    radar authored and Mauro Botelho committed Nov 30, 2011
  4. There's no admin/checkout controller. These routes don't do *anything*

    radar authored and Mauro Botelho committed Nov 30, 2011
  5. Write tests testing for stripped bcc and cc

    radar authored and Mauro Botelho committed Nov 30, 2011
  6. Remove empty before block in mail_interceptor_spec.rb

    radar authored and Mauro Botelho committed Nov 30, 2011
  7. use old hash syntax

    radar authored and Mauro Botelho committed Nov 30, 2011
    Fixes change introduced by a commit from #822
  8. Remove nonsense test from braintree spec

    radar authored and Mauro Botelho committed Nov 30, 2011
  9. Fix namespace reference in braintree_spec

    radar authored and Mauro Botelho committed Nov 30, 2011
  10. no need to pass format_as_currency in products_helper_spec

    radar authored and Mauro Botelho committed Nov 30, 2011
    it's the default option
  11. Mark two troublesome tests as pending

    radar authored and Mauro Botelho committed Nov 30, 2011
    They are failing on the CI server but not on dev machines. Will set up a Travis box locally and try it out later
  12. Fix 'attachment' spelling mistake in Image model

    radar authored and Mauro Botelho committed Nov 30, 2011
  13. You can now specify a symbol, which correpsonds with the name of a me…

    hoverlover authored and Mauro Botelho committed Nov 25, 2011
    …thod, instead of a Proc for the success and failure handlers in respond_override.
  14. Remove extra spaces as per my comments in #823

    radar authored and Mauro Botelho committed Nov 30, 2011
  15. get param_key by ActiveModel::Naming.param_key()

    tka authored and Mauro Botelho committed Nov 29, 2011
  16. use ActiveModel::Naming.param_key(@payment_methods) to get data from …

    tka authored and Mauro Botelho committed Nov 16, 2011
    …params
  17. pass :format_as_currency through to product_price in order to get a t…

    radar authored and Mauro Botelho committed Nov 29, 2011
    …est to pass
  18. Move middleware to engine

    radar authored and Mauro Botelho committed Nov 29, 2011
    Putting them in the application is silly. The engine has this capability already, so lets put it there.
    
    This also allows us to add more middleware if we require it
  19. Don't copy over assets to the application at all

    radar authored and Mauro Botelho committed Nov 29, 2011
    Assets belong in the engine
  20. Don't remove app/assets/javascripts/application.js, app/assets/styles…

    radar authored and Mauro Botelho committed Nov 29, 2011
    …heets/application.css or app/assets/images/rails.png
    
    People may be attached to these files and will most likely get pissy if we remove them
Commits on Nov 29, 2011
  1. Removed p statement.

    Mauro Botelho
    Mauro Botelho committed Nov 29, 2011
  2. [auth] Correct template references in admin_users_controller_spec

    radar authored and Mauro Botelho committed Nov 29, 2011
  3. Base controller decorator MUST be loaded before admin_controller_deco…

    radar authored and Mauro Botelho committed Nov 29, 2011
    …rator
    
    This is so the rescue_from for CanCan::AccessDenied is loaded into Spree::BaseController first.
    
    Otherwise, what happens is that Spree::Admin::BaseController gets defined, which loads Spree::BaseController and inherits its class_attributes from that. One of these is rescue_handlers, which at this stage is an empty array. This means that when this controller (or, more likely, one of its descendants) raises the CanCan::AccessDenied exception, the rescue handler is not registered and so the exception causes a *real* exception.
    
    By loading it before hand, the rescue_from call runs on Spree::BaseController before Spree::Admin::BaseController is loaded, meaning that when Spree::Admin::BaseController is *finally* loaded it inherits the rescue_handlers attribute from Spree::BaseController, so that when the CanCan::AccessDenied exception is thrown it is correctly rescued from.
    
    Thanks to adhlssu07 for pointing out this issue
  4. BigDecimal takes string as first arg

    radar authored and Mauro Botelho committed Nov 29, 2011
  5. Remove extra space from include() call in product/scopes_spec.rb

    radar authored and Mauro Botelho committed Nov 29, 2011
  6. Ensure configuration exists before each test

    radar authored and Mauro Botelho committed Nov 29, 2011
  7. Remove fixture loading from spec_helper as it is no longer necessary

    radar authored and Mauro Botelho committed Nov 29, 2011
  8. Mark troublesome tests as pending now. These MUST be fixed before we …

    radar authored and Mauro Botelho committed Nov 29, 2011
    …release 1.0
  9. Remove pending from customer details spec

    radar authored and Mauro Botelho committed Nov 29, 2011
  10. stub effective_amount in product_price test to cause calculator

    radar authored and Mauro Botelho committed Nov 28, 2011
  11. admin/products_controller no longer raises ActiveRecord::NotFound

    radar authored and Mauro Botelho committed Nov 28, 2011
    Instead, error is captured and flash error displays as 'Product is not found'
  12. Do not load seed data for test_app

    schof authored and Mauro Botelho committed Nov 28, 2011
  13. Correct namespace for FileUtilz constant. Fixes #822

    radar authored and Mauro Botelho committed Nov 28, 2011
Commits on Nov 28, 2011
  1. Making sure all specs pass.

    Mauro Botelho
    Mauro Botelho committed Nov 28, 2011