New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the getPagesTranscludedBy() function #88

Merged
merged 5 commits into from Jan 14, 2016

Conversation

Projects
None yet
2 participants
@ValentinBrclz
Contributor

ValentinBrclz commented Jan 2, 2016

No description provided.

@macbre

View changes

README.md Outdated
@@ -165,6 +165,10 @@ Gets the list of pages in a given namespace - [read more](http://www.mediawiki.o
Gets the list of pages by a given prefix - [read more](https://www.mediawiki.org/wiki/API:Allpages)
### bot.getPagesTranscludedBy(page, callback)
Gets the list of pages that are transcluded by the given page - [read more](https://www.mediawiki.org/wiki/API:Transcludedin)

This comment has been minimized.

@macbre

macbre Jan 3, 2016

Owner

Isn't the description a bit misleading here? The documentation says:

Find all pages that transclude the given pages

This comment has been minimized.

@ValentinBrclz

ValentinBrclz Jan 4, 2016

Contributor

That's right, thank you for checking that and making it clearer. I just corrected it. 😄

lib/bot.js Outdated
@@ -300,6 +300,22 @@ module.exports = (function() {
});
},
getPagesTranscludedBy: function (template, callback) {

This comment has been minimized.

@macbre

macbre Jan 14, 2016

Owner

So shouldn't this function be called a bit different, let's say getPagesWithTemplate?

This comment has been minimized.

@ValentinBrclz

ValentinBrclz Jan 14, 2016

Contributor

What about getPagesTranscluding()? The thing is that it is not necessary a template that is transcluded...

This comment has been minimized.

@macbre

macbre Jan 14, 2016

Owner

Sounds even better ;) 👍

@ValentinBrclz

This comment has been minimized.

Contributor

ValentinBrclz commented Jan 14, 2016

Done! 😄

macbre added a commit that referenced this pull request Jan 14, 2016

Merge pull request #88 from ValentinBrclz/gettransclusion
Adding the getPagesTranscludedBy() function

@macbre macbre merged commit 689bcf1 into macbre:devel Jan 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@macbre

This comment has been minimized.

Owner

macbre commented Jan 14, 2016

Thanks and sorry for the delayed feedback

@macbre macbre added the enhancement label Jan 14, 2016

@ValentinBrclz ValentinBrclz deleted the ValentinBrclz:gettransclusion branch Jan 14, 2016

@ValentinBrclz

This comment has been minimized.

Contributor

ValentinBrclz commented Jan 14, 2016

👍 No worries, we all have a life outside of github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment