Add "X-cache: PASS" support in cacheHits module #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var re = /miss|hit/i; | ||
| var re = /miss|hit|pass/i; | ||
|
|
||
| // examples: | ||
| // X-Cache:HIT, HIT | ||
| // X-Cache:arsenic miss (0) | ||
| phantomas.on('recv', function(entry,res) { | ||
| var header = entry.headers['X-Cache'] || '', |
There was a problem hiding this comment.
As toLowerCase() is now called twice on header I'd move the call here.
|
Makes perfect sense to me :) Please run JS Lint against your changes by |
| @@ -155,6 +155,7 @@ phantomas metrics for <https://github.com/macbre/phantomas>: | |||
| * otherSize: 0 | |||
| * cacheHits: 9 | |||
| * cacheMisses: 0 | |||
| * cachePasses: 0 | |||
There was a problem hiding this comment.
Please update information about number of metrics above (it got ++)
ghost
assigned
| isPass = header.toLowerCase().indexOf('pass') > -1; | ||
| if (isPass) { | ||
| phantomas.incrMetric('cachePasses'); | ||
| phantomas.log('Cache pass: on <' + entry.url + '> (X-Cache: ' + header + ')'); |
There was a problem hiding this comment.
You may want to use offenders (see #140) for reporting requests being passed to the backend. Simply call phantomas.addOffender('cachePasses', entry.url);
|
Way better :) Thanks, @kennydee! |
macbre
added a commit
that referenced
this pull request
Dec 14, 2013
Add "X-cache: PASS" support in cacheHits module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I don't know if this PR could have some interest for you, but in case ...
This PR add X-cache PASS metrics.
In our Varnish, we have HIT, MISS and PASS.
PASS tell us there is a rule which exclude cache on this request, and tell us which rules.
And PASS request, is a thing that we have to look, because it means that every hit go to the backend !
;) Thanks