Changed the registration of js functions #12

Merged
merged 1 commit into from May 14, 2013

Projects

None yet

2 participants

@SeriousM
Contributor

Hi,

I noticed you are using => instead of -> in the client/index.coffee file.
The problem is that this pollutes the window namespace.

I replaced all => with -> to avoid that.
Everything works fine with this change.

@maccman
Owner
maccman commented May 13, 2013

I'm not sure that's accurate. Aren't they on the Abba class?

@maccman maccman closed this May 13, 2013
@SeriousM
Contributor

They were on the Abba class but also registered on the current scope which is the window itself.
Please verify it yourself by checking the compiled js code from your version and mine.

@maccman
Owner
maccman commented May 14, 2013

I stand corrected!

@maccman maccman reopened this May 14, 2013
@maccman maccman merged commit c9fbbfb into maccman:master May 14, 2013
@SeriousM SeriousM deleted the SeriousM:namespace_issue branch May 14, 2013
@SeriousM
Contributor

btw, I think you will have the same problem with the other coffee scripts but that is not that serious because it is used only by the abba site itself.

Cheers & Thanks for that great project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment