Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Sprockets 2.2 - 2.8 #16

Merged
merged 3 commits into from Jan 7, 2013

Conversation

jamesarosen
Copy link
Contributor

  • add some basic tests
  • add Appraisals for each minor version of Sprockets 2
  • fix a compatibility issue with logical_path on Sprocket 2.3+

This replaces #15 (and expands compatibility).

@jamesarosen
Copy link
Contributor Author

@maccman this is somewhat time critical because Rails 2.3.10 patches a SQL injection attack and requires Sprockets 2.2.

maccman added a commit that referenced this pull request Jan 7, 2013
Compatibility with Sprockets 2.2 - 2.8
@maccman maccman merged commit afd3dc7 into maccman:master Jan 7, 2013
@maccman
Copy link
Owner

maccman commented Jan 7, 2013

Thanks. Sorry for the delay. @jamesarosen Do you want me to release a new version?

@jamesarosen
Copy link
Contributor Author

That would be fantastic :)

@jamesarosen jamesarosen deleted the james/sprockets-2-2-plus branch January 7, 2013 22:41
@maccman
Copy link
Owner

maccman commented Jan 7, 2013

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants