Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fix problem reported by Melvin Davidson relating to cleanup thread.

VACUUM/ANALYZE request return codes were being misinterpreted as errors.

Fixed this, so that:
 - Errors are reported as such
 - Warnings are reported as such

Also modified partitioning test to suppress autovac on at least one table
so that regression tests may be expected to exercise this code.
  • Loading branch information...
commit eee0e5fdc51cd7e2523f123ab2d58cb4c86f8757 1 parent 079d6ee
Christopher Browne authored
View
6 RELEASE
@@ -1,4 +1,4 @@
-$Id: RELEASE,v 1.3.2.10 2009-04-28 21:49:29 cbbrowne Exp $
+$Id: RELEASE,v 1.3.2.11 2009-05-01 15:29:25 cbbrowne Exp $
RELEASE 2.0.0
@@ -85,3 +85,7 @@ RELEASE 2.0.2
- Revised regression tests to use SYNC/WAIT FOR EVENT instead of
queries that try to coordinate sl_status information with rather
less determinacy...
+
+- Cleanup thread was generating spurious error messages due to
+ misinterpreting PG return codes. Rectified this, and added a
+ test in to make sure we're exercising the logic
View
5 tests/testpartition/README
@@ -1,4 +1,7 @@
-$Id: README,v 1.2 2007-09-06 16:12:00 cbbrowne Exp $
+$Id: README,v 1.2.2.1 2009-05-01 15:29:25 cbbrowne Exp $
testpartition sets up a partitioning test, periodically adding new
partitions.
+
+It alters pg_autovac configuration to ensure that some tables are being
+vacuumed by Slony-I.
View
3  tests/testpartition/generate_dml.sh
@@ -78,6 +78,9 @@ do_initdata()
wait_for_catchup
status "done"
+ $pgbindir/psql -h $host -p $port -d $db -U $user -c "insert into pg_catalog.pg_autovacuum (vacrelid, enabled, vac_base_thresh, vac_scale_factor, anl_base_thresh, anl_scale_factor, vac_cost_delay, vac_cost_limit, freeze_min_age, freeze_max_age) (select oid, 'f', 0, 0, 0, 0, 0,0,0,0 from pg_catalog.pg_class where relnamespace = (select oid from pg_namespace where nsp_name = '_${CLUSTER1}') and relname = 'sl_seqlog');" 1> $mktmp/suppressautovac.log 2> $mktmp/suppressautovac.log
+ status "make sure there is at least one table being vacuumed by Slony-I"
+
more_data
wait_for_catchup
status "done"
Please sign in to comment.
Something went wrong with that request. Please try again.