forked from cockroachdb/cockroach
-
Notifications
You must be signed in to change notification settings - Fork 0
/
backup.go
975 lines (884 loc) · 29.7 KB
/
backup.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
// Copyright 2016 The Cockroach Authors.
//
// Licensed under the Cockroach Community Licence (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://github.com/cockroachdb/cockroach/blob/master/pkg/ccl/LICENSE
package sqlccl
import (
"bytes"
"io/ioutil"
"sort"
"strings"
"golang.org/x/net/context"
"github.com/cockroachdb/cockroach/pkg/ccl/storageccl"
"github.com/cockroachdb/cockroach/pkg/ccl/utilccl"
"github.com/cockroachdb/cockroach/pkg/ccl/utilccl/intervalccl"
"github.com/cockroachdb/cockroach/pkg/internal/client"
"github.com/cockroachdb/cockroach/pkg/keys"
"github.com/cockroachdb/cockroach/pkg/roachpb"
"github.com/cockroachdb/cockroach/pkg/sql"
"github.com/cockroachdb/cockroach/pkg/sql/parser"
"github.com/cockroachdb/cockroach/pkg/sql/privilege"
"github.com/cockroachdb/cockroach/pkg/sql/sqlbase"
"github.com/cockroachdb/cockroach/pkg/util/hlc"
"github.com/cockroachdb/cockroach/pkg/util/interval"
"github.com/cockroachdb/cockroach/pkg/util/log"
"github.com/cockroachdb/cockroach/pkg/util/syncutil"
"github.com/cockroachdb/cockroach/pkg/util/tracing"
"github.com/pkg/errors"
)
const (
// BackupDescriptorName is the file name used for serialized
// BackupDescriptor protos.
BackupDescriptorName = "BACKUP"
backupOptIntoDB = "into_db"
)
// ReadBackupDescriptor reads and unmarshals a BackupDescriptor from given base.
func ReadBackupDescriptor(
ctx context.Context, dir storageccl.ExportStorage,
) (BackupDescriptor, error) {
r, err := dir.ReadFile(ctx, BackupDescriptorName)
if err != nil {
return BackupDescriptor{}, err
}
defer r.Close()
descBytes, err := ioutil.ReadAll(r)
if err != nil {
return BackupDescriptor{}, err
}
var backupDesc BackupDescriptor
if err := backupDesc.Unmarshal(descBytes); err != nil {
return BackupDescriptor{}, err
}
// TODO(dan): Sanity check this BackupDescriptor: non-empty EndTime,
// non-empty Paths, and non-overlapping Spans and keyranges in Files.
return backupDesc, nil
}
// ValidatePreviousBackups checks that the timestamps of previous backups are
// consistent. The most recently backed-up time is returned.
func ValidatePreviousBackups(ctx context.Context, uris []string) (hlc.Timestamp, error) {
if len(uris) == 0 || len(uris) == 1 && uris[0] == "" {
// Full backup.
return hlc.Timestamp{}, nil
}
backups := make([]BackupDescriptor, len(uris))
for i, uri := range uris {
dir, err := storageccl.ExportStorageFromURI(ctx, uri)
if err != nil {
return hlc.Timestamp{}, err
}
backups[i], err = ReadBackupDescriptor(ctx, dir)
if err != nil {
return hlc.Timestamp{}, err
}
}
// This reuses Restore's logic for lining up all the start and end
// timestamps to validate the previous backups that this one is incremental
// from.
_, endTime, err := makeImportRequests(nil, backups)
return endTime, err
}
func allSQLDescriptors(txn *client.Txn) ([]sqlbase.Descriptor, error) {
startKey := roachpb.Key(keys.MakeTablePrefix(keys.DescriptorTableID))
endKey := startKey.PrefixEnd()
rows, err := txn.Scan(startKey, endKey, 0)
if err != nil {
return nil, err
}
sqlDescs := make([]sqlbase.Descriptor, len(rows))
for i, row := range rows {
if err := row.ValueProto(&sqlDescs[i]); err != nil {
return nil, errors.Wrapf(err, "%s: unable to unmarshal SQL descriptor", row.Key)
}
}
return sqlDescs, nil
}
// spansForAllTableIndexes returns non-overlapping spans for every index and
// table passed in. They would normally overlap if any of them are interleaved.
func spansForAllTableIndexes(tables []*sqlbase.TableDescriptor) []roachpb.Span {
sstIntervalTree := interval.Tree{Overlapper: interval.Range.OverlapExclusive}
for _, table := range tables {
for _, index := range table.AllNonDropIndexes() {
startKey := roachpb.Key(sqlbase.MakeIndexKeyPrefix(table, index.ID))
ie := intervalSpan(roachpb.Span{Key: startKey, EndKey: startKey.PrefixEnd()})
// Errors are only returned if end <= start, which is never the case
// here because we use `PrefixEnd` to compute end.
_ = sstIntervalTree.Insert(ie, false)
}
}
var spans []roachpb.Span
_ = sstIntervalTree.Do(func(r interval.Interface) bool {
spans = append(spans, roachpb.Span{
Key: roachpb.Key(r.Range().Start),
EndKey: roachpb.Key(r.Range().End),
})
return false
})
return spans
}
type backupFileDescriptors []BackupDescriptor_File
func (r backupFileDescriptors) Len() int { return len(r) }
func (r backupFileDescriptors) Swap(i, j int) { r[i], r[j] = r[j], r[i] }
func (r backupFileDescriptors) Less(i, j int) bool {
if cmp := bytes.Compare(r[i].Span.Key, r[j].Span.Key); cmp != 0 {
return cmp < 0
}
return bytes.Compare(r[i].Span.EndKey, r[j].Span.EndKey) < 0
}
// Backup exports a snapshot of every kv entry into ranged sstables.
//
// The output is an sstable per range with files in the following locations:
// - <dir>/<unique_int>.sst
// - <dir> is given by the user and may be cloud storage
// - Each file contains data for a key range that doesn't overlap with any other
// file.
func Backup(
ctx context.Context,
p sql.PlanHookState,
uri string,
targets parser.TargetList,
startTime, endTime hlc.Timestamp,
_ parser.KVOptions,
) (BackupDescriptor, error) {
// TODO(dan): Figure out how permissions should work. #6713 is tracking this
// for grpc.
var sqlDescs []sqlbase.Descriptor
exportStore, err := storageccl.ExportStorageFromURI(ctx, uri)
if err != nil {
return BackupDescriptor{}, err
}
defer exportStore.Close()
db := *p.ExecCfg().DB
{
txn := client.NewTxn(ctx, db)
opt := client.TxnExecOptions{AutoRetry: true, AutoCommit: true}
err := txn.Exec(opt, func(txn *client.Txn, opt *client.TxnExecOptions) error {
var err error
sql.SetTxnTimestamps(txn, endTime)
sqlDescs, err = allSQLDescriptors(txn)
return err
})
if err != nil {
return BackupDescriptor{}, err
}
}
// TODO(dan): Plumb the session database down.
sessionDatabase := ""
if sqlDescs, err = descriptorsMatchingTargets(sessionDatabase, sqlDescs, targets); err != nil {
return BackupDescriptor{}, err
}
for _, desc := range sqlDescs {
if dbDesc := desc.GetDatabase(); dbDesc != nil {
if err := p.CheckPrivilege(dbDesc, privilege.SELECT); err != nil {
return BackupDescriptor{}, err
}
}
}
// Backup users, descriptors, and the entire keyspace for user data.
tables := []*sqlbase.TableDescriptor{&sqlbase.DescriptorTable, &sqlbase.UsersTable}
for _, desc := range sqlDescs {
if tableDesc := desc.GetTable(); tableDesc != nil {
tables = append(tables, tableDesc)
}
}
for _, desc := range tables {
if err := p.CheckPrivilege(desc, privilege.SELECT); err != nil {
return BackupDescriptor{}, err
}
}
spans := spansForAllTableIndexes(tables)
mu := struct {
syncutil.Mutex
files []BackupDescriptor_File
dataSize int64
}{}
var wg syncutil.WaitGroupWithError
header := roachpb.Header{Timestamp: endTime}
storageConf := exportStore.Conf()
for i := range spans {
wg.Add(1)
go func(span roachpb.Span) {
req := &roachpb.ExportRequest{
Span: span,
Storage: storageConf,
StartTime: startTime,
}
res, pErr := client.SendWrappedWith(ctx, db.GetSender(), header, req)
if pErr != nil {
wg.Done(pErr.GoError())
return
}
mu.Lock()
defer mu.Unlock()
for _, file := range res.(*roachpb.ExportResponse).Files {
mu.files = append(mu.files, BackupDescriptor_File{
Span: file.Span,
Path: file.Path,
Sha512: file.Sha512,
})
mu.dataSize += file.DataSize
}
wg.Done(nil)
}(spans[i])
}
if err := wg.Wait(); err != nil {
return BackupDescriptor{}, errors.Wrapf(err, "exporting %d ranges", len(spans))
}
files, dataSize := mu.files, mu.dataSize // No more concurrency, so this is safe.
desc := BackupDescriptor{
StartTime: startTime,
EndTime: endTime,
Descriptors: sqlDescs,
Spans: spans,
Files: files,
DataSize: dataSize,
}
sort.Sort(backupFileDescriptors(desc.Files))
descBuf, err := desc.Marshal()
if err != nil {
return BackupDescriptor{}, err
}
writer, err := exportStore.PutFile(ctx, BackupDescriptorName)
if err != nil {
return BackupDescriptor{}, err
}
defer writer.Cleanup()
if err = ioutil.WriteFile(writer.LocalFile(), descBuf, 0600); err != nil {
return BackupDescriptor{}, err
}
if err := writer.Finish(); err != nil {
return BackupDescriptor{}, err
}
return desc, nil
}
// Import loads some data in sstables into an empty range. Only the keys between
// startKey and endKey are loaded. Every row's key is rewritten to be for
// newTableID.
func Import(
ctx context.Context,
db client.DB,
startKey, endKey roachpb.Key,
files []roachpb.ImportRequest_File,
kr storageccl.KeyRewriter,
) error {
if log.V(1) {
log.Infof(ctx, "import %s-%s (%d files)", startKey, endKey, len(files))
}
if len(files) == 0 {
return nil
}
newStartKey, ok := kr.RewriteKey(append([]byte(nil), startKey...))
if !ok {
return errors.Errorf("could not rewrite key: %s", startKey)
}
req := &roachpb.ImportRequest{
// Import is a point request because we don't want DistSender to split
// it. Assume (but don't require) the entire post-rewrite span is on the
// same range.
Span: roachpb.Span{Key: newStartKey},
DataSpan: roachpb.Span{
Key: startKey,
EndKey: endKey,
},
Files: files,
KeyRewrites: kr,
}
b := &client.Batch{}
b.AddRawRequest(req)
return db.Run(ctx, b)
}
func reassignParentIDs(
txn *client.Txn,
p sql.PlanHookState,
databasesByID map[sqlbase.ID]*sqlbase.DatabaseDescriptor,
tables []*sqlbase.TableDescriptor,
opt parser.KVOptions,
) error {
for _, table := range tables {
// Update the parentID to point to the named DB in the new cluster.
{
var targetDB string
if override, ok := opt.Get(backupOptIntoDB); ok {
targetDB = override
} else {
database, ok := databasesByID[table.ParentID]
if !ok {
return errors.Errorf("no database with ID %d in backup for table %q", table.ParentID, table.Name)
}
targetDB = database.Name
}
// Make sure the target DB exists.
existingDatabaseID, err := txn.Get(sqlbase.MakeNameMetadataKey(0, targetDB))
if err != nil {
return err
}
if existingDatabaseID.Value == nil {
return errors.Errorf("a database named %q needs to exist to restore table %q",
targetDB, table.Name)
}
newParentID, err := existingDatabaseID.Value.GetInt()
if err != nil {
return err
}
table.ParentID = sqlbase.ID(newParentID)
}
// Check that the table name is _not_ in use.
// This would fail the CPut later anyway, but this yields a prettier error.
{
nameKey := table.GetNameMetadataKey()
res, err := txn.Get(nameKey)
if err != nil {
return err
}
if res.Exists() {
return sqlbase.NewRelationAlreadyExistsError(table.Name)
}
}
// Check and set privileges.
{
parentDB, err := sqlbase.GetDatabaseDescFromID(txn, table.ParentID)
if err != nil {
return errors.Wrapf(err, "failed to lookup parent DB %d", table.ParentID)
}
if err := p.CheckPrivilege(parentDB, privilege.CREATE); err != nil {
return err
}
// Default is to copy privs from restoring parent db, like CREATE TABLE.
// TODO(dt): Make this more configurable.
{
table.Privileges = parentDB.GetPrivileges()
}
}
}
return nil
}
func newTableIDs(
ctx context.Context,
db client.DB,
databasesByID map[sqlbase.ID]*sqlbase.DatabaseDescriptor,
tables []*sqlbase.TableDescriptor,
) (map[sqlbase.ID]sqlbase.ID, error) {
var newTableIDs map[sqlbase.ID]sqlbase.ID
newTableIDsFunc := func(txn *client.Txn) error {
newTableIDs = make(map[sqlbase.ID]sqlbase.ID, len(tables))
for _, table := range tables {
newTableID, err := sql.GenerateUniqueDescID(txn)
if err != nil {
return err
}
newTableIDs[table.ID] = newTableID
}
return nil
}
if err := db.Txn(ctx, newTableIDsFunc); err != nil {
return nil, err
}
return newTableIDs, nil
}
type intervalSpan roachpb.Span
var _ interval.Interface = intervalSpan{}
// ID is part of `interval.Interface` but unused in makeImportRequests.
func (ie intervalSpan) ID() uintptr { return 0 }
// Range is part of `interval.Interface`.
func (ie intervalSpan) Range() interval.Range {
return interval.Range{Start: []byte(ie.Key), End: []byte(ie.EndKey)}
}
type importEntryType int
const (
backupSpan importEntryType = iota
backupFile
tableSpan
request
)
type importEntry struct {
roachpb.Span
entryType importEntryType
// Only set if entryType is backupSpan
backup BackupDescriptor
// Only set if entryType is backupFile
dir roachpb.ExportStorage
file BackupDescriptor_File
// Only set if entryType is request
files []roachpb.ImportRequest_File
}
// makeImportRequests pivots the backups, which are grouped by time, into
// requests for import, which are grouped by keyrange.
//
// The core logic of this is in OverlapCoveringMerge, which accepts sets of
// non-overlapping key ranges (aka coverings) each with a payload, and returns
// them aligned with the payloads in the same order as in the input.
//
// Example (input):
// - [A, C) backup t0 to t1 -> /file1
// - [C, D) backup t0 to t1 -> /file2
// - [A, B) backup t1 to t2 -> /file3
// - [B, C) backup t1 to t2 -> /file4
// - [C, D) backup t1 to t2 -> /file5
// - [B, D) requested table data to be restored
//
// Example (output):
// - [A, B) -> /file1, /file3
// - [B, C) -> /file1, /file4, requested (note that file1 was split into two ranges)
// - [C, D) -> /file2, /file5, requested
//
// This would be turned into two Import requests, one restoring [B, C) out of
// /file1 and /file3, the other restoring [C, D) out of /file2 and /file5.
// Nothing is restored out of /file3 and only part of /file1 is used.
//
// NB: All grouping operates in the pre-rewrite keyspace, meaning the keyranges
// as they were backed up, not as they're being restored.
func makeImportRequests(
tables []*sqlbase.TableDescriptor, backups []BackupDescriptor,
) ([]importEntry, hlc.Timestamp, error) {
// Put the merged table data covering first into the OverlapCoveringMerge
// input.
var tableSpanCovering intervalccl.Covering
for _, span := range spansForAllTableIndexes(tables) {
tableSpanCovering = append(tableSpanCovering, intervalccl.Range{
Start: span.Key,
End: span.EndKey,
Payload: importEntry{
Span: span,
entryType: tableSpan,
},
})
}
backupCoverings := []intervalccl.Covering{tableSpanCovering}
// Iterate over backups creating two coverings for each. First the spans
// that were backed up, then the files in the backup. The latter is a subset
// when some of the keyranges in the former didn't change since the previous
// backup. These alternate (backup1 spans, backup1 files, backup2 spans,
// backup2 files) so they will retain that alternation in the output of
// OverlapCoveringMerge.
var maxEndTime hlc.Timestamp
for _, b := range backups {
if maxEndTime.Less(b.EndTime) {
maxEndTime = b.EndTime
}
var backupSpanCovering intervalccl.Covering
for _, s := range b.Spans {
backupSpanCovering = append(backupSpanCovering, intervalccl.Range{
Start: s.Key,
End: s.EndKey,
Payload: importEntry{Span: s, entryType: backupSpan, backup: b},
})
}
backupCoverings = append(backupCoverings, backupSpanCovering)
var backupFileCovering intervalccl.Covering
for _, f := range b.Files {
backupFileCovering = append(backupFileCovering, intervalccl.Range{
Start: f.Span.Key,
End: f.Span.EndKey,
Payload: importEntry{
Span: f.Span,
entryType: backupFile,
dir: b.Dir,
file: f,
},
})
}
backupCoverings = append(backupCoverings, backupFileCovering)
}
// Group ranges covered by backups with ones needed to restore the selected
// tables. Note that this breaks intervals up as necessary to align them.
// See the function godoc for details.
importRanges := intervalccl.OverlapCoveringMerge(backupCoverings)
// Translate the output of OverlapCoveringMerge into requests.
var requestEntries []importEntry
for _, importRange := range importRanges {
needed := false
var ts hlc.Timestamp
var files []roachpb.ImportRequest_File
payloads := importRange.Payload.([]interface{})
for _, p := range payloads {
ie := p.(importEntry)
switch ie.entryType {
case tableSpan:
needed = true
case backupSpan:
if ts != ie.backup.StartTime {
return nil, hlc.Timestamp{}, errors.Errorf(
"no backup covers time [%s,%s) for range [%s,%s) (or backups out of order)",
ts, ie.backup.StartTime,
roachpb.Key(importRange.Start), roachpb.Key(importRange.End))
}
ts = ie.backup.EndTime
case backupFile:
if len(ie.file.Path) > 0 {
files = append(files, roachpb.ImportRequest_File{
Dir: ie.dir,
Path: ie.file.Path,
Sha512: ie.file.Sha512,
})
}
}
}
if ts != maxEndTime {
return nil, hlc.Timestamp{}, errors.Errorf(
"no backup covers time [%s,%s) for range [%s,%s) (or backups out of order)",
ts, maxEndTime, roachpb.Key(importRange.Start), roachpb.Key(importRange.End))
}
if needed {
// If needed is false, we have data backed up that is not necessary
// for this restore. Skip it.
requestEntries = append(requestEntries, importEntry{
Span: roachpb.Span{Key: importRange.Start, EndKey: importRange.End},
entryType: request,
files: files,
})
}
}
return requestEntries, maxEndTime, nil
}
// presplitRanges concurrently creates the splits described by `input`. It does
// this by finding the middle key, splitting and recursively presplitting the
// resulting left and right hand ranges. NB: The split code assumes that the LHS
// of the resulting ranges is the smaller, so normally you'd split from the
// left, but this method should only be called on empty keyranges, so it's okay.
//
// The `input` parameter expected to be sorted.
func presplitRanges(baseCtx context.Context, db client.DB, input []roachpb.Key) error {
// TODO(dan): This implementation does nothing to control the maximum
// parallelization or number of goroutines spawned. Revisit (possibly via a
// semaphore) if this becomes a problem in practice.
ctx, span := tracing.ChildSpan(baseCtx, "presplitRanges")
defer tracing.FinishSpan(span)
if len(input) == 0 {
return nil
}
var wg syncutil.WaitGroupWithError
var splitFn func([]roachpb.Key)
splitFn = func(splitPoints []roachpb.Key) {
// Pick the index such that it's 0 if len(splitPoints) == 1.
splitIdx := len(splitPoints) / 2
// AdminSplit requires that the key be a valid table key, which means
// the last byte is a uvarint indicating how much of the end of the key
// needs to be stripped off to get the key's row prefix. The start keys
// input to restore don't have this suffix, so make them row sentinels,
// which means nothing should be stripped (aka appends 0). See
// EnsureSafeSplitKey for more context.
splitKey := append([]byte(nil), splitPoints[splitIdx]...)
splitKey = keys.MakeRowSentinelKey(splitKey)
if err := db.AdminSplit(ctx, splitKey); err != nil {
if !strings.Contains(err.Error(), "already split at") {
log.Errorf(ctx, "presplitRanges: %+v", err)
wg.Done(err)
return
}
}
splitPointsLeft, splitPointsRight := splitPoints[:splitIdx], splitPoints[splitIdx+1:]
if len(splitPointsLeft) > 0 {
wg.Add(1)
go splitFn(splitPointsLeft)
}
if len(splitPointsRight) > 0 {
wg.Add(1)
// Save a few goroutines by reusing this one.
splitFn(splitPointsRight)
}
wg.Done(nil)
}
wg.Add(1)
splitFn(input)
return wg.Wait()
}
func restoreTableDescs(
ctx context.Context,
db client.DB,
databasesByID map[sqlbase.ID]*sqlbase.DatabaseDescriptor,
tables []*sqlbase.TableDescriptor,
newTableIDs map[sqlbase.ID]sqlbase.ID,
) ([]sqlbase.TableDescriptor, error) {
ctx, span := tracing.ChildSpan(ctx, "restoreTableDescs")
defer tracing.FinishSpan(span)
newTables := make([]sqlbase.TableDescriptor, len(tables))
restoreTableDescsFunc := func(txn *client.Txn) error {
for i := range tables {
newTables[i] = *tables[i]
newTableID, ok := newTableIDs[newTables[i].ID]
if !ok {
return errors.Errorf("missing table ID for %d %q", newTables[i].ID, newTables[i].Name)
}
newTables[i].ID = newTableID
if err := newTables[i].ForeachNonDropIndex(func(index *sqlbase.IndexDescriptor) error {
// TODO(dan): We need this sort of logic for FKs, too.
for j := range index.Interleave.Ancestors {
newTableID, ok = newTableIDs[index.Interleave.Ancestors[j].TableID]
if !ok {
return errors.Errorf("not restoring %d", index.Interleave.Ancestors[j].TableID)
}
index.Interleave.Ancestors[j].TableID = newTableID
}
oldInterleavedBy := index.InterleavedBy
index.InterleavedBy = nil
for _, ib := range oldInterleavedBy {
if newTableID, ok = newTableIDs[ib.Table]; ok {
newIB := ib
newIB.Table = newTableID
index.InterleavedBy = append(index.InterleavedBy, newIB)
}
}
return nil
}); err != nil {
return err
}
// Pass the descriptors by value to keep this idempotent.
if err := restoreTableDesc(ctx, txn, newTables[i]); err != nil {
return err
}
}
for _, newTable := range newTables {
if err := newTable.Validate(txn); err != nil {
return err
}
}
return nil
}
if err := db.Txn(ctx, restoreTableDescsFunc); err != nil {
return nil, err
}
return newTables, nil
}
func restoreTableDesc(ctx context.Context, txn *client.Txn, table sqlbase.TableDescriptor) error {
// Write the new descriptors. First the ID -> TableDescriptor for the new
// table, then flip (or initialize) the name -> ID entry so any new queries
// will use the new one. If there was an existing table, it can now be
// cleaned up.
b := txn.NewBatch()
b.CPut(table.GetDescMetadataKey(), sqlbase.WrapDescriptor(&table), nil)
b.CPut(table.GetNameMetadataKey(), table.ID, nil)
return txn.Run(b)
}
// Restore imports a SQL table (or tables) from sets of non-overlapping sstable
// files.
func Restore(
ctx context.Context,
p sql.PlanHookState,
uris []string,
targets parser.TargetList,
opt parser.KVOptions,
) ([]sqlbase.TableDescriptor, error) {
backupDescs := make([]BackupDescriptor, len(uris))
db := *p.ExecCfg().DB
if len(targets.Databases) > 0 {
return nil, errors.Errorf("RESTORE DATABASE is not yet supported " +
"(but you can use 'RESTORE somedb.*' to restore all backed up tables for a given DB).")
}
for i, uri := range uris {
dir, err := storageccl.ExportStorageFromURI(ctx, uri)
if err != nil {
return nil, errors.Wrapf(err, "failed to create export storage handler from %q", uri)
}
backupDescs[i], err = ReadBackupDescriptor(ctx, dir)
if err != nil {
return nil, errors.Wrap(err, "failed to read backup descriptor")
}
backupDescs[i].Dir = dir.Conf()
}
if len(backupDescs) == 0 {
return nil, errors.Errorf("no backups found")
}
lastBackupDesc := backupDescs[len(backupDescs)-1]
databasesByID := make(map[sqlbase.ID]*sqlbase.DatabaseDescriptor)
var tables []*sqlbase.TableDescriptor
{
// TODO(dan): Plumb the session database down.
sessionDatabase := ""
sqlDescs := lastBackupDesc.Descriptors
var err error
if sqlDescs, err = descriptorsMatchingTargets(sessionDatabase, sqlDescs, targets); err != nil {
return nil, err
}
for _, desc := range sqlDescs {
if dbDesc := desc.GetDatabase(); dbDesc != nil {
databasesByID[dbDesc.ID] = dbDesc
} else if tableDesc := desc.GetTable(); tableDesc != nil {
if tableDesc.ParentID == keys.SystemDatabaseID {
return nil, errors.Errorf("cannot restore system table: %s", tableDesc.Name)
}
tables = append(tables, tableDesc)
}
}
if len(tables) == 0 {
return nil, errors.Errorf("no tables found: %s", parser.AsString(targets))
}
}
// Fail fast if the necessary databases don't exist since the below logic
// leaks table IDs when Restore fails.
if err := db.Txn(ctx, func(txn *client.Txn) error {
return reassignParentIDs(txn, p, databasesByID, tables, opt)
}); err != nil {
return nil, err
}
// Assign a new ID for each table. This will leak if Restore later returns
// an error, but we can't use a KV transaction as restarts would be terrible
// (and our bulk import primitives are non-transactional).
//
// TODO(dan): For now, we're always generating a new ID, but varints get
// longer as they get bigger and so our keys will, too. We should someday
// figure out how to reclaim ids.
newTableIDs, err := newTableIDs(ctx, db, databasesByID, tables)
if err != nil {
return nil, errors.Wrapf(err, "reserving %d new table IDs for restore", len(tables))
}
kr, err := MakeKeyRewriterForNewTableIDs(tables, newTableIDs)
if err != nil {
return nil, errors.Wrapf(err, "creating key rewriter for %d tables", len(tables))
}
// Verify that for any interleaved index being restored, the interleave
// parent is also being restored. Otherwise, the interleave entries in the
// restored IndexDescriptors won't have anything to point to.
// TODO(dan): It seems like this restriction could be lifted by restoring
// stub TableDescriptors for the missing interleave parents.
for _, table := range tables {
for _, index := range table.AllNonDropIndexes() {
for _, a := range index.Interleave.Ancestors {
if _, ok := newTableIDs[a.TableID]; !ok {
return nil, errors.Errorf(
"cannot restore table %q without interleave parent table %d",
table.Name, a.TableID)
}
}
for _, d := range index.InterleavedBy {
if _, ok := newTableIDs[d.Table]; !ok {
return nil, errors.Errorf(
"cannot restore table %q without interleave child table %d",
table.Name, d.Table)
}
}
}
}
// Pivot the backups, which are grouped by time, into requests for import,
// which are grouped by keyrange.
importRequests, _, err := makeImportRequests(tables, backupDescs)
if err != nil {
return nil, errors.Wrapf(err, "making import requests for %d backups", len(backupDescs))
}
// The Import (and resulting WriteBatch) requests made below run on
// leaseholders, so presplit the ranges to balance the work among many
// nodes.
splitKeys := make([]roachpb.Key, len(importRequests))
for i, r := range importRequests {
var ok bool
splitKeys[i], ok = kr.RewriteKey(append([]byte(nil), r.Key...))
if !ok {
return nil, errors.Errorf("failed to rewrite key: %s", r.Key)
}
}
if err := presplitRanges(ctx, db, splitKeys); err != nil {
return nil, errors.Wrapf(err, "presplitting %d ranges", len(importRequests))
}
// TODO(dan): Wait for the newly created ranges (and leaseholders) to
// rebalance.
var wg syncutil.WaitGroupWithError
for i := range importRequests {
wg.Add(1)
go func(i importEntry) {
wg.Done(Import(ctx, db, i.Key, i.EndKey, i.files, kr))
}(importRequests[i])
}
if err := wg.Wait(); err != nil {
// This leaves the data that did get imported in case the user wants to
// retry.
// TODO(dan): Build tooling to allow a user to restart a failed restore.
return nil, errors.Wrapf(err, "importing %d ranges", len(importRequests))
}
// Write the new TableDescriptors and flip the namespace entries over to
// them. After this call, any queries on a table will be served by the newly
// restored data.
// TODO(dan): Gossip this out and wait for any outstanding leases to expire.
newTables, err := restoreTableDescs(ctx, db, databasesByID, tables, newTableIDs)
if err != nil {
return nil, errors.Wrapf(err, "restoring %d TableDescriptors", len(tables))
}
// TODO(dan): Delete any old table data here. The first version of restore
// assumes that it's operating on a new cluster. If it's not empty,
// everything works but the table data is left abandoned.
return newTables, nil
}
func backupPlanHook(
baseCtx context.Context, stmt parser.Statement, p sql.PlanHookState,
) (func() ([]parser.Datums, error), sql.ResultColumns, error) {
backup, ok := stmt.(*parser.Backup)
if !ok {
return nil, nil, nil
}
if err := utilccl.CheckEnterpriseEnabled("BACKUP"); err != nil {
return nil, nil, err
}
if err := p.RequireSuperUser("BACKUP"); err != nil {
return nil, nil, err
}
header := sql.ResultColumns{
{Name: "to", Typ: parser.TypeString},
{Name: "startTs", Typ: parser.TypeString},
{Name: "endTs", Typ: parser.TypeString},
{Name: "dataSize", Typ: parser.TypeInt},
}
fn := func() ([]parser.Datums, error) {
// TODO(dan): Move this span into sql.
ctx, span := tracing.ChildSpan(baseCtx, stmt.StatementTag())
defer tracing.FinishSpan(span)
var startTime hlc.Timestamp
if backup.IncrementalFrom != nil {
var err error
startTime, err = ValidatePreviousBackups(ctx, backup.IncrementalFrom)
if err != nil {
return nil, err
}
}
endTime := p.ExecCfg().Clock.Now()
if backup.AsOf.Expr != nil {
var err error
if endTime, err = sql.EvalAsOfTimestamp(nil, backup.AsOf, endTime); err != nil {
return nil, err
}
}
desc, err := Backup(ctx,
p,
backup.To,
backup.Targets,
startTime, endTime,
backup.Options,
)
if err != nil {
return nil, err
}
ret := []parser.Datums{{
parser.NewDString(backup.To),
parser.NewDString(startTime.String()),
parser.NewDString(endTime.String()),
parser.NewDInt(parser.DInt(desc.DataSize)),
}}
return ret, nil
}
return fn, header, nil
}
func restorePlanHook(
baseCtx context.Context, stmt parser.Statement, p sql.PlanHookState,
) (func() ([]parser.Datums, error), sql.ResultColumns, error) {
restore, ok := stmt.(*parser.Restore)
if !ok {
return nil, nil, nil
}
if err := utilccl.CheckEnterpriseEnabled("RESTORE"); err != nil {
return nil, nil, err
}
if err := p.RequireSuperUser("RESTORE"); err != nil {
return nil, nil, err
}
fn := func() ([]parser.Datums, error) {
// TODO(dan): Move this span into sql.
ctx, span := tracing.ChildSpan(baseCtx, stmt.StatementTag())
defer tracing.FinishSpan(span)
_, err := Restore(ctx, p, restore.From, restore.Targets, restore.Options)
return nil, err
}
return fn, nil, nil
}
func init() {
sql.AddPlanHook(backupPlanHook)
sql.AddPlanHook(restorePlanHook)
}