Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuild v1.0 image? #1

Closed
VojtechVitek opened this issue Nov 1, 2019 · 4 comments
Closed

Prebuild v1.0 image? #1

VojtechVitek opened this issue Nov 1, 2019 · 4 comments

Comments

@VojtechVitek
Copy link

@VojtechVitek VojtechVitek commented Nov 1, 2019

Hi,
I'm testing https://github.com/marketplace/actions/get-kubeconfig-file-from-gke for the first time today and so far it works great! Thank you!

The only annoying thing I noticed is that Docker Action job actually triggers docker build for this image on every single build, even if I specify @v1.0 instead of @latest.

Would it be possible to prebuild this Docker image somehow/somewhere, so it can be docker pulled from a registry?

@issue-label-bot

This comment has been minimized.

Copy link

@issue-label-bot issue-label-bot bot commented Nov 1, 2019

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.71. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@VojtechVitek

This comment has been minimized.

Copy link
Author

@VojtechVitek VojtechVitek commented Nov 4, 2019

FYI, I've built github.com/machine-learning-apps/gke-kubeconfig Dockerfile and published the image on Docker Hub:

This is the time difference between the build times:

uses: machine-learning-apps/gke-kubeconfig@1.0

Screen Shot 2019-11-04 at 1 02 37 PM

uses: docker://pressly/gke-kubeconfig:1.0

Screen Shot 2019-11-04 at 1 03 54 PM

@hamelsmu

This comment has been minimized.

Copy link
Collaborator

@hamelsmu hamelsmu commented Nov 23, 2019

Hey @VojtechVitek I'll fix this soon, I'll create an Action in this repo that pre-builds it

@hamelsmu

This comment has been minimized.

Copy link
Collaborator

@hamelsmu hamelsmu commented Nov 24, 2019

I believe this is fixed now, closing issue feel free to reopen

@hamelsmu hamelsmu closed this Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.