Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis should only build API or Dashboard image when respective code has changed #43

Closed
ckadner opened this issue May 18, 2021 · 2 comments · Fixed by #45
Closed

Travis should only build API or Dashboard image when respective code has changed #43

ckadner opened this issue May 18, 2021 · 2 comments · Fixed by #45
Assignees

Comments

@ckadner
Copy link
Member

ckadner commented May 18, 2021

From @Tomcli:

... we can leverage the script we have wrote for kfp-tekton. This way we don't need to build the image if the api/ui code hasn't changed

https://github.com/kubeflow/kfp-tekton/blob/master/.travis.yml#L73-L95

Originally posted by @Tomcli in #27 (comment)

@ckadner ckadner assigned Tomcli and unassigned Tomcli May 18, 2021
@ckadner
Copy link
Member Author

ckadner commented May 18, 2021

This is a good idea @Tomcli -- let me know if you want to add this? Otherwise I will create a PR for it.

@Tomcli
Copy link
Member

Tomcli commented May 18, 2021

I can put up something simple to start with. What we have in kfp-tekton is to check whether any source file in our dockerfiles has changed, if so run the docker build. You can update the script later on if you want to check for diff in a specific dockerfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants