-
Notifications
You must be signed in to change notification settings - Fork 212
Correctly convert remote port bytecode to uint16 port number. #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Copied the network_to_host_short function from the ASIO library to convert the remote port byte code to a uint16 number.
bsergean
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix !
|
The build fails on windows, I think it's because uint16_t is unknown. Can you try to add a header like #include ? |
bsergean
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes to fix the build error, which should be a simple one
https://stackoverflow.com/questions/17436527/error-uint16-t-undeclared
|
mac_tsan_mbedtls / mac_tsan_mbedtls (pull_request) that test can be ignored. |
|
Updated to use |
|
Thanks that should fix it, I just fired the CI to see. Can you change the implementation file too (the .cpp one) so that things are consistent ? |
|
Thanks @stryker250 ! / I have merged your change, I'll fix that small thing myself. I will make a release after. If your company or yourself wants to, you can add a reference in the README in the USERs section, or I can do it for you if it's ok. Or do nothing, up to you :) |
Copied the network_to_host_short function from the ASIO library to convert the remote port byte code to a uint16 number.
This resolves the issue noted in #320