Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quoteless action param deprecation #137

Merged
merged 2 commits into from Mar 18, 2014

Conversation

BenV
Copy link
Contributor

@BenV BenV commented Mar 13, 2014

This attempts to resolve the following deprecation warning which you get when using the shorthand notation for actions, etc (http://jsbin.com/jevev/2/edit)

DEPRECATION: Using a quoteless parameter with {{action}} is deprecated. Please update to quoted usage '{{action "blah"}}.
        at Object.handleRegisteredAction [as handler] (http://builds.emberjs.com/tags/v1.4.0/ember.js:37742:17)
        at HTMLAnchorElement.handleActionEvent (http://builds.emberjs.com/tags/v1.4.0/ember.js:21916:25)
        at Object.Ember.handleErrors (http://builds.emberjs.com/tags/v1.4.0/ember.js:907:17)
        at HTMLAnchorElement.<anonymous> (http://builds.emberjs.com/tags/v1.4.0/ember.js:21908:20)
        at HTMLBodyElement.jQuery.event.dispatch (http://code.jquery.com/jquery-2.0.2.js:4692:9)
        at HTMLBodyElement.elemData.handle (http://code.jquery.com/jquery-2.0.2.js:4377:6) 

I couldn't come up with a good test case for this, but that is likely because I am very new to pegjs and emblem in general. Suggestions for a test are very welcome, but it seems like this change needed to be made at a pretty low level. Here's a JSBin using an emblem.js from my branch: http://jsbin.com/jevev/1/edit - notice you can click the link without getting a warning in the console.

Also, I had to base this branch off of my other pull request to ensure the tests were all passing: #136

Please let me know if you have any suggestions for changes, or if there is anything else I can do to help 馃槃

machty added a commit that referenced this pull request Mar 18, 2014
Fix quoteless action param deprecation
@machty machty merged commit 7a36536 into machty:master Mar 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants