Migrate vmm_callout -> OSX libdispatch #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyhu
requested changes
Dec 3, 2018
|
Have you done any performance comparisons before and after your changes? |
|
Just rebased on master. |
|
Tried the Tiny Linux boot, and it still works with the rebased version. I have run performance tests in the past (2 years ago) and they looked better than the original implementation (and if I just could remember how did I they looked like!). What would you suggest, how to exercise it? I think it would make sense to test it again. |
|
@machyve/write-access do you think this still something that is worth to merge? I can try to spend some time on it to get it tested again. |
…urrency bug. The bug may occur in callout_stop_safe when queued is still not 0 and we call dispatch_suspend on a released object, can happen only during draining.
|
@bonifaido it seems like project is semi-dead. |
|
@jeremyhu can you take a look on this? |
fengjixuchui
added a commit
to fengjixuchui/xhyve
that referenced
this pull request
Nov 11, 2021
Migrate vmm_callout -> OSX libdispatch (machyve#112)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to be a cleaner implementation then the current one, based upon what I saw in README.md - TODO I thought it was a good idea to migrate it. I wouldn't say it is complete, but it could be a good starting point. I haven't seen any issues by running a VM for a couple of hours with multiple sleeps with this patch.