vbsc_ident buffer accessed out of bounds #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adopt src/pci_ahci.c logic
struct ahci_port {
...
char ident[20 + 1];
...
}
as they both hold the MD5 sum. Also while at it start using snprintf.
Signed-off-by: S.Çağlar Onur <caglar@10ur.org>
|
If you are super awesome you could also file a bug report against bhyve (since it is not an xhyve speficic issue) ;) |
mist64
added a commit
that referenced
this pull request
Jun 14, 2015
vbsc_ident buffer accessed out of bounds
uqs
pushed a commit
to freebsd/freebsd-src
that referenced
this pull request
Nov 20, 2018
to avoid buffer accessed out of bounds, also switch to snprintf(3). PR: 200859 Submitted by: Caglar <caglar@10ur.org> Obtained from: machyve/xhyve#24 MFC after: 4 weeks Sponsored by: iXsystems Inc. git-svn-id: svn+ssh://svn.freebsd.org/base/head@340707 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
uqs
pushed a commit
to freebsd/freebsd-src
that referenced
this pull request
Nov 20, 2018
to avoid buffer accessed out of bounds, also switch to snprintf(3). PR: 200859 Submitted by: Caglar <caglar@10ur.org> Obtained from: machyve/xhyve#24 MFC after: 4 weeks Sponsored by: iXsystems Inc.
mat813
pushed a commit
to mat813/freebsd
that referenced
this pull request
Nov 21, 2018
to avoid buffer accessed out of bounds, also switch to snprintf(3). PR: 200859 Submitted by: Caglar <caglar@10ur.org> Obtained from: machyve/xhyve#24 MFC after: 4 weeks Sponsored by: iXsystems Inc. git-svn-id: https://svn.freebsd.org/base/head@340707 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
brooksdavis
pushed a commit
to CTSRD-CHERI/cheribsd
that referenced
this pull request
Nov 27, 2018
to avoid buffer accessed out of bounds, also switch to snprintf(3). PR: 200859 Submitted by: Caglar <caglar@10ur.org> Obtained from: machyve/xhyve#24 MFC after: 4 weeks Sponsored by: iXsystems Inc.
uqs
pushed a commit
to freebsd/freebsd-src
that referenced
this pull request
Dec 18, 2018
Define AHCI_PORT_IDENT and increase by 1 the VTBLK_BLK_ID_BYTES to avoid buffer accessed out of bounds, also switch to snprintf(3). PR: 200859 Submitted by: Caglar <caglar@10ur.org> Obtained from: machyve/xhyve#24
mat813
pushed a commit
to mat813/freebsd
that referenced
this pull request
Dec 21, 2018
Define AHCI_PORT_IDENT and increase by 1 the VTBLK_BLK_ID_BYTES to avoid buffer accessed out of bounds, also switch to snprintf(3). PR: 200859 Submitted by: Caglar <caglar@10ur.org> Obtained from: machyve/xhyve#24 git-svn-id: https://svn.freebsd.org/base/stable/12@342184 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
bsdimp
pushed a commit
to bsdimp/freebsd
that referenced
this pull request
Dec 31, 2018
to avoid buffer accessed out of bounds, also switch to snprintf(3). PR: 200859 Submitted by: Caglar <caglar@10ur.org> Obtained from: machyve/xhyve#24 MFC after: 4 weeks Sponsored by: iXsystems Inc. git-svn-id: svn+ssh://svn.freebsd.org/base/head@340707 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt src/pci_ahci.c logic
struct ahci_port {
...
char ident[20 + 1];
...
}
as they both hold the MD5 sum. Also while at it start using snprintf.
Signed-off-by: S.Çağlar Onur caglar@10ur.org