New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[check-log] When specified multiple pattern, perform search that satisfies all conditions #174

Merged
merged 7 commits into from May 29, 2017

Conversation

Projects
None yet
5 participants
@a-know
Member

a-know commented May 22, 2017

Current specification of check-log , it is difficult to satisfy AND as the log monitoring condition.

This p-r is to make it possible to perform log monitoring that satisfies all the patterns when multiple --pattern are specified.

@stefafafan

This comment has been minimized.

Show comment
Hide comment
@stefafafan

stefafafan May 23, 2017

Member

The code seems correct, just not sure if, the points below are okay.

  • specifying multiple --pattern
  • show error when warning/critical is specified for multiple

Also, if we are going to allow multiple --pattern , it may be nice to also write that in the README of checklog.

Member

stefafafan commented May 23, 2017

The code seems correct, just not sure if, the points below are okay.

  • specifying multiple --pattern
  • show error when warning/critical is specified for multiple

Also, if we are going to allow multiple --pattern , it may be nice to also write that in the README of checklog.

Show outdated Hide outdated check-log/lib/check-log.go Outdated

a-know added some commits May 23, 2017

Show outdated Hide outdated check-log/lib/check-log.go Outdated
@itchyny

This comment has been minimized.

Show comment
Hide comment
@itchyny

itchyny May 29, 2017

Contributor

LGTM

Contributor

itchyny commented May 29, 2017

LGTM

@astj astj merged commit cd72bb2 into master May 29, 2017

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.9%) to 56.619%
Details

@astj astj deleted the check-log-multiple-pattern branch May 29, 2017

@Songmu Songmu referenced this pull request Jun 7, 2017

Merged

Release version 0.10.4 #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment