Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ntservice] Enable to specify service name to exclude from match #279

Merged
merged 7 commits into from Mar 18, 2019

Conversation

Projects
None yet
2 participants
@a-know
Copy link
Member

a-know commented Mar 16, 2019

No description provided.

-s, --service-name= service name
-l, --list-service list service
-s, --service-name= service name
-E, --exclude-service= service name to exclude from matching

This comment has been minimized.

Copy link
@lufia

lufia Mar 18, 2019

Contributor

I think traditional commands such as diff, tar, or du use often x|X character for meaning exclude instead of e|E, or no short notation.

This comment has been minimized.

Copy link
@a-know

a-know Mar 18, 2019

Author Member

I was not certain the character, either. I follow your point, ee53b4b .

},
}

mockServiceState()

This comment has been minimized.

Copy link
@lufia

lufia Mar 18, 2019

Contributor

This test had better reset getServiceStateFunc to initial state. Because tests that run after this test could be able to break.

For example:

originalFunc := getServiceStateFunc
defer func(){
    getServiceStateFunc = originalFunc
}()
mockServiceState()

This comment has been minimized.

Copy link
@a-know

a-know Mar 18, 2019

Author Member

That's true! I fix it, effeb49 .

@lufia

lufia approved these changes Mar 18, 2019

Copy link
Contributor

lufia left a comment

LGTM! Thank you for your contribution.

@a-know a-know merged commit ece83f2 into master Mar 18, 2019

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 59.077%
Details

@a-know a-know deleted the exclude-service-name branch Mar 18, 2019

@lufia lufia referenced this pull request Mar 27, 2019

Merged

Release version 0.29.0 #282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.